Opened 4 years ago

Closed 4 years ago

#49010 closed enhancement (fixed)

ccpnmr: add new gcc5 variant as default compiler to ccpnmr-2.4.2a

Reported by: howarth.at.macports@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.3
Keywords: haspatch Cc: dstrubbe (David Strubbe)
Port: ccpnmr

Description

The attached Portfile.diff adds the missing gcc5 variant to the ccpnmr 2.4.2 packaging and changes the default variant from gcc4.8 to gcc5.

Attachments (1)

Portfile.diff (2.2 KB) - added by howarth.at.macports@… 4 years ago.
Use active_variants PortGroup rather than the compiler PortGroup to avoid blacklisting compilers.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by mf2k (Frank Schima)

This port should instead be modified to use the compilers Portgroup.

comment:2 Changed 4 years ago by howarth.at.macports@…

The compiler Portgboup seems to be undocumented in https://guide.macports.org/#reference.portgroup so it is unclear what is the most proper way to implement in order to support just the system compilers and the desired gcc releases. Do I have to blacklist everything else?

comment:3 Changed 4 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added
Summary: add new gcc5 variant as default compiler to ccpnmr-2.4.2ccpnmr: add new gcc5 variant as default compiler to ccpnmr-2.4.2a
Type: updateenhancement

Changed 4 years ago by howarth.at.macports@…

Attachment: Portfile.diff added

Use active_variants PortGroup rather than the compiler PortGroup to avoid blacklisting compilers.

comment:4 Changed 4 years ago by howarth.at.macports@…

Use active_variants PortGroup. I really don't want to mess with the compiler PortGroup as it would require blacklisting compilers rather than just listing those supported as variants.

comment:5 Changed 4 years ago by dstrubbe (David Strubbe)

All you need is: "compilers.setup -g95 -dragonegg". You don't need to blacklist, you just need to list what you don't want included (e.g. g95 and dragonegg Fortran compilers).

comment:6 Changed 4 years ago by dstrubbe (David Strubbe)

Documentation for the compilers port group is in the file itself: dports/_resources/port1.0/group/compilers-1.0.tcl. I just added a lot more documentation there.

comment:7 Changed 4 years ago by dstrubbe (David Strubbe)

Cc: dstrubbe@… added

Cc Me!

comment:8 Changed 4 years ago by seanfarley (Sean Farley)

I can take a crack at using compilers port group this weekend. Maybe someone can use this to help start documentation?

comment:9 Changed 4 years ago by seanfarley (Sean Farley)

Resolution: fixed
Status: newclosed

Fixed this in r144223.

Note: See TracTickets for help on using tickets.