Opened 8 years ago

Closed 4 years ago

#49033 closed enhancement (wontfix)

mongo-cxx-driver @1.0.5 Add a cxx11 variant

Reported by: julien.pilet@… Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: chrstphrchvz (Christopher Chavez)
Port: mongo-cxx-driver

Description

C++11 ABI changed. If mongo-cxx-driver is to be linked with c++11 code, it needs to be compiled with --c++=on. see https://jira.mongodb.org/browse/CXX-558

This change adds a cxx11 variant to enable the --c++11=on compile flag.

Attachments (1)

mongo-cxx-driver.diff (813 bytes) - added by julien.pilet@… 8 years ago.

Download all attachments as: .zip

Change History (8)

Changed 8 years ago by julien.pilet@…

Attachment: mongo-cxx-driver.diff added

comment:1 Changed 8 years ago by julien.pilet@…

Actually my patch does not work, and I do not know why. When I add --c++11=on to the list of build args, it works. With build.args-append and port install mongo-cxx-driver +cxx11, it does not.

Is my syntax correct?

comment:2 Changed 8 years ago by mf2k (Frank Schima)

Cc: ryandesign openmaintainer removed
Owner: changed from macports-tickets@… to ryandesign@…
Version: 2.3.3

Trac requires complete email addresses. Please do not Cc openmaintainer@… because it is not a valid email address.

comment:3 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

The variant description is much too verbose.

There is no reason to increase the port's revision.

Your syntax is correct, but in its present form the port is not designed to accommodate variants changing the build args. Note that the destroot.args get set to the build.args; that happens before variants are evaluated.

If I understand you correctly, some software would require mongo-cxx-driver compiled without C++11 support, and some software would require mongo-cxx-driver compiled with C++11 support. Is that correct? If so, it might be better to have a new subport for mongo-cxx-driver–with–C++11, and ideally, the developers of mongo-cxx-driver would have their software install both, so that the consumer of the library can choose which one to use.

Last edited 8 years ago by ryandesign (Ryan Carsten Schmidt) (previous) (diff)

comment:4 Changed 8 years ago by julien.pilet@…

When I develop, I use C++11, so I need to compile with --c++11=on. You are correct.

I guess the point of a subport is to have the possibility of having both versions installed at the same time? I do not know how to do that properly.

I know that the mongo-cxx-driver developers are working on a new version (see https://github.com/mongodb/mongo-cxx-driver#repository-overview). The new version will have c++11 anyway.

comment:5 Changed 4 years ago by chrstphrchvz (Christopher Chavez)

mongo-cxx-driver has been updated several times, most recently to 3.5.1, and has been compiled with C++11 support. Is this ticket still relevant, or can it be closed?

comment:6 Changed 4 years ago by chrstphrchvz (Christopher Chavez)

Cc: chrstphrchvz added

comment:7 Changed 4 years ago by ryandesign (Ryan Carsten Schmidt)

Resolution: wontfix
Status: newclosed

No longer relevant now that mongo-cxx-driver always requires C++11.

Note: See TracTickets for help on using tickets.