Opened 9 years ago
Closed 9 years ago
#49082 closed update (wontfix)
OpenCoarrays @1.0.3 adding mpstats as dependency
| Reported by: | fanfarillo.gcc@… | Owned by: | macports-tickets@… |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.4 |
| Keywords: | Cc: | ||
| Port: | OpenCoarrays |
Description
Hi,
tracking users download is a very important statistics for our open source project. We would like to have mpstats as dependent library for OpenCoarrays. The attached patch should do the job.
Comments?
Cheers
Alessandro
Attachments (1)
Change History (5)
Changed 9 years ago by fanfarillo.gcc@…
| Attachment: | Portfile-OpenCoarrays.diff added |
|---|
comment:1 Changed 9 years ago by pixilla (Bradley Giesbrecht)
comment:2 follow-up: 3 Changed 9 years ago by raimue (Rainer Müller)
Yes, the revision should have been increased when changing the list of dependencies. Please remember to include a reference to the ticket in the commit message for the record of maintainer approval.
We should not force users to install mpstats as its tracking is meant to be opt-in only. Please revert this change.
comment:3 follow-up: 4 Changed 9 years ago by pixilla (Bradley Giesbrecht)
Replying to raimue@…:
Yes, the revision should have been increased when changing the list of dependencies. Please remember to include a reference to the ticket in the commit message for the record of maintainer approval.
We should not force users to install mpstats as its tracking is meant to be opt-in only. Please revert this change.
Done in r140816
I'm surprised the mpstats port auto-activates reporting. There appears to be no way of fixing a situation like this where the ramifications of depending on mpstat was unknown. Wouldn't the mpstat port be safer if it required "port load mpstats"?
comment:4 Changed 9 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → wontfix |
|---|---|
| Status: | new → closed |
Replying to pixilla@…:
I'm surprised the mpstats port auto-activates reporting. There appears to be no way of fixing a situation like this where the ramifications of depending on mpstat was unknown. Wouldn't the mpstat port be safer if it required "port load mpstats"?
You could discuss that on the mailing list or open a new ticket.
Done in r140813.
Anyone with OpenCoarrays already installed will not pull in mpstats through this dependency until the OpenCoarrays version or revision increases. Should we increase the revision?