Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#49173 closed update (fixed)

tmux tmux-devel git hash update

Reported by: tessus (Helmut K. C. Tessarek) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc: kurthindenburg (Kurt Hindenburg)
Port: tmux tmux-devel

Description

Updated Portfile to replace commit point for tmux-devel.

see also Tickets: #49121

Attachments (1)

Portfile-tmux.diff (1.2 KB) - added by tessus (Helmut K. C. Tessarek) 4 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 4 years ago by tessus (Helmut K. C. Tessarek)

I can't change it from defect to update. Can someone please add permissions for me so that I can modify my own tickets?

comment:2 Changed 4 years ago by mf2k (Frank Schima)

Type: defectupdate
Version: 2.3.4

There is no way to give that to you short of you becoming a Macports team member. I have updated the ticket.

Note, the revision line should be deleted because it starts at 0 when increasing the version and that is the default value.

comment:3 Changed 4 years ago by tessus (Helmut K. C. Tessarek)

Guys, you really should have a finer access control for the ticketing system AND for the repositories. This feels like 20 years ago.

Anyway, I never added the revision keyword. Somebody must have added it w/o my knowledge (after my last update). I haven't noticed it, since I only updated the git hash and the checksums.

I'll remove it right away.

Changed 4 years ago by tessus (Helmut K. C. Tessarek)

Attachment: Portfile-tmux.diff added

comment:4 Changed 4 years ago by tessus (Helmut K. C. Tessarek)

removed revision and re-attached

comment:5 Changed 4 years ago by ryandesign (Ryan Schmidt)

Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned

The revision of the main port should not be dropped to 0. Only the revision of the tmux-devel port that you're updating should be dropped to 0.

comment:6 Changed 4 years ago by tessus (Helmut K. C. Tessarek)

The thing is that I never set the revision for the main port to 1, so I don't even know why this was done in the first place. But I defer to your judgement, since you know the system better than I.

Please make the necessary adjustment or let me know, if I should re-upload a new diff. Cheers.

comment:7 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:8 Changed 4 years ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

Updated in r141019.

You should not be surprised if the revision of a port you maintain is increased without your prior consultation. Sometimes it is necessary to make such a change. In this case, the revision was increased when ncurses was upgraded to version 6 in r139469, which necessitated a simultaneous rebuilding of all ports that use ncurses, which includes tmux.

comment:9 Changed 4 years ago by tessus (Helmut K. C. Tessarek)

Ah, thanks for the info. That makes sense, I just couldn't really see why it was done. Maybe I'm too spoilt by git. I haven't used svn for a long time now and totally forgot to use "svn log".

Note: See TracTickets for help on using tickets.