Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#49218 closed update (fixed)

vaucanson: rename to vcsn and update to 2.1

Reported by: akimd (Akim Demaille) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: haspatch maintainer Cc: kurthindenburg (Kurt Hindenburg)
Port: vaucanson

Description

Hi,

Vcsn 2.1 was released. The package used to be named Vaucanson, it has been renamed as Vcsn, but I don't know how portfiles can reflect this...

Attachments (7)

vcsn.patch (2.5 KB) - added by akimd (Akim Demaille) 5 years ago.
Portfile (1.6 KB) - added by akimd (Akim Demaille) 5 years ago.
vaucanson.macports (361 bytes) - added by akimd (Akim Demaille) 5 years ago.
Portfile for obsoleting Vaucanson
vcsn.macports (1.3 KB) - added by akimd (Akim Demaille) 5 years ago.
Candidate Portfile for Vcsn
vaucanson2vcsn.patch (2.5 KB) - added by akimd (Akim Demaille) 5 years ago.
Diff from accepted vaucanson Portfile to candidate vcsn Portfile
2.1-to-2.2.patch (949 bytes) - added by akimd (Akim Demaille) 5 years ago.
vcsn.2.macports (1.6 KB) - added by akimd (Akim Demaille) 5 years ago.
Portfile for Vcsn 2.2

Download all attachments as: .zip

Change History (19)

Changed 5 years ago by akimd (Akim Demaille)

Attachment: vcsn.patch added

Changed 5 years ago by akimd (Akim Demaille)

Attachment: Portfile added

comment:1 Changed 5 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch maintainer added
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned
Summary: Vcsn 2.1 is releasedvaucanson: rename to vcsn and update to 2.1

Thanks. I assume you are the maintainer of this port? Your email address in this Trac ticket does not match the one listed in the portfile.

MacPorts can accommodate renamed ports. See PortfileRecipes#replaced-by.

You added a library dependency on lib:libltdl:libport but we have no port called "libport". libltdl is part of the libtool port; is that what you meant? If so, it should be written "port:libtool". "lib:"-style dependencies are only used when it is desired to allow non-MacPorts software to satisfy the dependency, and usually we do not desire that.

You added a runtime dependency on port:ccache. Usually ccache is used at build time, at the discretion of the user and their macports.conf settings. Is ccache really needed at runtime? If so, the dependency should be written "path:bin/ccache:ccache" to allow the ccache-devel port to satisfy the dependency.

Some of the compilers you've blacklisted don't exist anymore, for example "*clang-2.*". The oldest clang we have in MacPorts today is clang-3.3.

Since this project requires C++11, it should probably start by using the cxx11 1.0 portgroup, which sets some blacklisting and other necessary options. The blacklist can then be augmented if the project has compiler restrictions above and beyond the need for C++11.

comment:2 in reply to:  1 Changed 5 years ago by akimd (Akim Demaille)

Replying to ryandesign@…:

Hi Ryan! Thanks for taking care of this.

Thanks. I assume you are the maintainer of this port? Your email address in this Trac ticket does not match the one listed in the portfile.

I'm the maintainer of Vcsn. Yes, I'm akim@….

MacPorts can accommodate renamed ports. See PortfileRecipes#replaced-by.

You added a library dependency on lib:libltdl:libport but we have no port called "libport". libltdl is part of the libtool port; is that what you meant? If so, it should be written "port:libtool". "lib:"-style dependencies are only used when it is desired to allow non-MacPorts software to satisfy the dependency, and usually we do not desire that.

OK. I don't know where I took this line from. Note that there is

depends_run         path:lib/libltdl.a:libtool

provided as an example there: https://guide.macports.org/chunked/reference.dependencies.html

You added a runtime dependency on port:ccache. Usually ccache is used at build time, at the discretion of the user and their macports.conf settings. Is ccache really needed at runtime? If so, the dependency should be written "path:bin/ccache:ccache" to allow the ccache-devel port to satisfy the dependency.

OK, I fixed that. Yes, vcsn runs compilation at runtime, and uses ccache to ensure that modules that were previously compiled will no longer be recompiled.

Some of the compilers you've blacklisted don't exist anymore, for example "*clang-2.*". The oldest clang we have in MacPorts today is clang-3.3.

Since this project requires C++11, it should probably start by using the cxx11 1.0 portgroup, which sets some blacklisting and other necessary options. The blacklist can then be augmented if the project has compiler restrictions above and beyond the need for C++11.

Good to know, thanks!

I have attached two Portfiles: one for vcsn, another for obsoleting Vaucanson. I have also added a new diff from the previous vaucanson Portfile to the new vcsn Port file. Thanks again!

Changed 5 years ago by akimd (Akim Demaille)

Attachment: vaucanson.macports added

Portfile for obsoleting Vaucanson

Changed 5 years ago by akimd (Akim Demaille)

Attachment: vcsn.macports added

Candidate Portfile for Vcsn

Changed 5 years ago by akimd (Akim Demaille)

Attachment: vaucanson2vcsn.patch added

Diff from accepted vaucanson Portfile to candidate vcsn Portfile

comment:3 Changed 5 years ago by akimd (Akim Demaille)

Ping!

comment:4 Changed 5 years ago by akimd (Akim Demaille)

Ping!

comment:5 Changed 5 years ago by akimd (Akim Demaille)

Hi,

Is there something I can/should do to help?

comment:6 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:7 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Akim, I added this in r144823

I had to make a lot of changes - can you test and let me know if there are any issues? When it works, I'll obsolete the other port.

You can use 'sudo port -t install' which adds --trace which will find dependencies that are needed

also 'sudo port -v test'

comment:8 Changed 5 years ago by akimd (Akim Demaille)

Hi!

First, sorry for not being more responsive, I've been too busy lately :(

Thanks *a lot*! This is brilliant! I tried it, and it works perfectly. There are issues for the test suite though, related to missing permissions for ccache. I'll post details later.

I see that you removed the -O3. Actually, the style used to implement Vcsn is very demanding on the compiler to get rid of the abstraction penalty, and -O3 is related needed to get the expected performances.

Thanks again! It's great news!

Version 0, edited 5 years ago by akimd (Akim Demaille) (next)

comment:9 Changed 5 years ago by akimd (Akim Demaille)

Hi!

Vcsn 2.2 was released.

I attached the updated Portfile, and the diff.

Cheers!

Changed 5 years ago by akimd (Akim Demaille)

Attachment: 2.1-to-2.2.patch added

Changed 5 years ago by akimd (Akim Demaille)

Attachment: vcsn.2.macports added

Portfile for Vcsn 2.2

comment:10 Changed 5 years ago by akimd (Akim Demaille)

Ping!

comment:11 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: assignedclosed

done

r147445 r147446 vaucanson

comment:12 Changed 5 years ago by akimd (Akim Demaille)

Thanks a lot!

Note: See TracTickets for help on using tickets.