cppcheck @1.70_0: following advice in note leads to warnings

[dstrubbe (David Strubbe)]

When cppcheck installs, it suggests running the command

sudo find /opt/local/share/cppcheck -type f -name "*.cfg.dist" -exec bash -c 'f="{}"; mv "$f" "${f%.cfg.dist}.cfg"' \;

I did that in another terminal, as various other ports were upgrading. At the end, a number of warnings were written about these files being missing:

--->  Updating database of binaries
Warning: Error determining file type of `/opt/local/share/cppcheck/avr.cfg.dist': lstat(/opt/local/share/cppcheck/avr.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
Warning: Error determining file type of `/opt/local/share/cppcheck/gnu.cfg.dist': lstat(/opt/local/share/cppcheck/gnu.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
Warning: Error determining file type of `/opt/local/share/cppcheck/gtk.cfg.dist': lstat(/opt/local/share/cppcheck/gtk.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
Warning: Error determining file type of `/opt/local/share/cppcheck/microsoft_sal.cfg.dist': lstat(/opt/local/share/cppcheck/microsoft_sal.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
Warning: Error determining file type of `/opt/local/share/cppcheck/posix.cfg.dist': lstat(/opt/local/share/cppcheck/posix.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
Warning: Error determining file type of `/opt/local/share/cppcheck/qt.cfg.dist': lstat(/opt/local/share/cppcheck/qt.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
Warning: Error determining file type of `/opt/local/share/cppcheck/sdl.cfg.dist': lstat(/opt/local/share/cppcheck/sdl.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
Warning: Error determining file type of `/opt/local/share/cppcheck/std.cfg.dist': lstat(/opt/local/share/cppcheck/std.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
Warning: Error determining file type of `/opt/local/share/cppcheck/windows.cfg.dist': lstat(/opt/local/share/cppcheck/windows.cfg.dist):no such file or directory
Warning: A file belonging to the `cppcheck' port is missing or unreadable. Consider reinstalling it.
--->  Scanning binaries for linking errors               
--->  No broken files found.                             

I suggest that 'cp' rather than 'mv' be used in the recommended command. Then the original files will still be there (and also for reference, if they are modified) and a warning will not be written.

[xythobuz@…]

Using 'cp' instead of 'mv' is a good suggestion, thank you very much!

A patch changing this is attached.

[dstrubbe (David Strubbe)]

Committed in r141299.