Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#49459 closed submission (fixed)

routino @3.0 port submission

Reported by: ramundsen85 Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: kurthindenburg (Kurt Hindenburg)
Port: routino

Description

I'd like to propose to add routino to MacPorts. It is a route planner for OpenStreetMap data.

qlandkartegt, which is also part of MacPorts is not developed anymore and is succeeded by qmapshack, which has routino as dependency. The port can be used as a simple route planner, an example can be found here: http://www.routino.org/documentation/usage.html

Tested under OS X 10.11 with Xcode 7.1 Any comment on the Portfile is very much appreciated.

Attachments (4)

patch-Makefile_conf.diff (689 bytes) - added by ramundsen85 5 years ago.
patch to build dynamic libraries with dylib extension
patch-src_Makefile_dylib_extension.diff (1.2 KB) - added by ramundsen85 5 years ago.
change library extension from so to dylib
routino.diff (1.2 KB) - added by kurthindenburg (Kurt Hindenburg) 5 years ago.
patch on Portfile - suggest fixes
Portfile (1.9 KB) - added by ramundsen85 5 years ago.

Download all attachments as: .zip

Change History (15)

Changed 5 years ago by ramundsen85

Attachment: patch-Makefile_conf.diff added

patch to build dynamic libraries with dylib extension

Changed 5 years ago by ramundsen85

change library extension from so to dylib

comment:1 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:2 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

I don't see anything major wrong. We do however try to add new ports only if they have a maintainer - are you willing to do that?

  1. distname can be removed - default works
  2. livecheck can be removed - default works
  3. add depends on bzip2 and libzip (try using "sudo port -t build" which will show dependencies)
  4. I would suggest removing doc variant and just including the docs as default

comment:3 in reply to:  2 Changed 5 years ago by ramundsen85

Thank you very much for your comments, of course I'll adopt all of them. But allow me two questions:

  1. How can I see bzip2 and libzip dependency, sudo port -t build gives only standard output for me:
    $ sudo port -t build
    --->  Fetching distfiles for routino
    --->  Verifying checksums for routino
    --->  Extracting routino
    --->  Applying patches to routino
    --->  Configuring routino
    --->  Building routino
    
  2. livecheck default works, but how? According to the guide freecode will be used as default for livecheck.type, routino is not listed there.

Replying to khindenburg@…:

We do however try to add new ports only if they have a maintainer - are you willing to do that?

Yes, this is fine with me, let's give it a try.

Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Attachment: routino.diff added

patch on Portfile - suggest fixes

comment:4 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

take a look at the diff - let me know if you have any concerns.

  1. You can use 'otool -L <library' to determine what libraries are using - we try to use macports' libraries if possible
  2. If a Portfile has no livecheck.*, there are default which are used (try using 'port -d livecheck'

comment:5 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

When using -t you should this output

--->  Building routino
Warning: The following existing files were hidden from the build system by trace mode:
  /opt/local/bin/perl
  /opt/local/include/bzlib.h
  /opt/local/include/zlib.h
  /opt/local/lib/libbz2.a
  /opt/local/lib/libbz2.dylib
  /opt/local/lib/libz.a
  /opt/local/lib/libz.dylib

this tells you that it is using the system libraries.

comment:6 Changed 5 years ago by ramundsen85

  1. With otool I found the dependencies, but as I said, trace mode has no such output for me.
  2. With debug mode I found master-sites.tcl, which answers all my livecheck questions, it seems guide is out of date.

Portfile with all changes (your patch) and changed maintainers tag will follow. Thanks for your help!

comment:7 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

I forgot about this ticket; we should try to use the right compiler UsingTheRightCompiler

I'll see if I can easily fix it

Last edited 4 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:8 in reply to:  7 Changed 5 years ago by ramundsen85

If I understand 'Using The Right Compiler' correctly, setting the CC and LD variable to ${configure.cc} before the build phase, is enough.

I'll attach an updated Portfile.

Changed 5 years ago by ramundsen85

Attachment: Portfile added

comment:9 Changed 5 years ago by kurthindenburg (Kurt Hindenburg)

Yea that doesn't really help. I think if we want to commit this as is and try to fix this issue later.

UsingTheRightCompiler#testing

Last edited 4 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:10 in reply to:  9 Changed 5 years ago by ramundsen85

Replying to khindenburg@…:

UsingTheRightCompiler#testing

That's exactly what I did before I posted the updated Portfile. Did I miss something?

Last edited 4 years ago by ryandesign (Ryan Schmidt) (previous) (diff)

comment:11 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

Sorry for the delay - you can always ping a ticket and/or ping the mailing list

If you want to open a new ticket to update to 3.1.1 go ahead and add me and I'll commit it for you

r153886

Note: See TracTickets for help on using tickets.