p5.22-pdl fails to build with gsl 2.0

[newville@…]

On a freshly installed MacPorts 2.3.4 on El Capitan,

sudo port -v install p5.22-pdl gives

make[4]: Entering directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_perl_p5-pdl/p5.22-pdl/work/PDL-2.013/Lib/GSL/SF/ellint'
/usr/bin/clang -c  "-I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_perl_p5-pdl/p5.22-pdl/work/PDL-2.013/Basic/Core"   -I/opt/local/include -pipe -Os -fno-common -DPERL_DARWIN -I/opt/local/include -fno-strict-aliasing -fstack-protector-strong -I/opt/local/include -arch x86_64 -O3   -DVERSION=\"2.013\" -DXS_VERSION=\"2.013\"  "-I/opt/local/lib/perl5/5.22/darwin-thread-multi-2level/CORE"   ELLINT.c
ELLINT.xs:1736:159: error: too many arguments to function call, expected 4, have 5
GSLERR(gsl_sf_ellint_D_e,((phi_datap)[0] PDL_COMMENT("ACCESS()") ,(k_datap)[0] PDL_COMMENT("ACCESS()") ,(n_datap)[0] PDL_COMMENT("ACCESS()") ,GSL_PREC_DOUBLE,&r))
       ~~~~~~~~~~~~~~~~~                                                                                                                                      ^~
./../gslerr.h:5:37: note: expanded from macro 'GSLERR'
#define GSLERR(x,y) if ((status = x y)) {snprintf(buf,200,"Error in %s: %s", #x, gsl_strerror(status));barf("%s", buf);}
                                    ^
/opt/local/include/gsl/gsl_sf_ellint.h:84:1: note: 'gsl_sf_ellint_D_e' declared here
int gsl_sf_ellint_D_e(double phi, double k, gsl_mode_t mode, gsl_sf_result * result);


1 error generated.
make[4]: *** [ELLINT.o] Error 1

gsl is version 2.0

[dbevans (David B. Evans)]

This build error is reproducible on Yosemite using gsl 2.0 so not an El Capitan issue per se. Build is successful with previous version of gsl (version 1.16).

[dbevans (David B. Evans)]

Build log showing build failure on Yosemite

[dbevans (David B. Evans)]

Error persists attempting update to current PDL version 2.014.

[dbevans (David B. Evans)]

Issue is due to removal of unused argument n from functions gsl_sf_ellint_D(), gsl_sf_ellint_D_e() in gsl 2.0+.

See ​http://git.savannah.gnu.org/cgit/gsl.git/commit/?id=de2ed0d0768f6e206f8cc7b07f2842b3f0b17843

[dbevans (David B. Evans)]

p5-pdl updated to version 2.014 and tentative patch applied to fix build issue in r142499. Let us know if this works for you on El Capitan. Thanks for your report.

[dbevans (David B. Evans)]

Build tested successfully on El Capitan (10.11.2 public beta3, Xcode 7.1.1)