Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#49753 closed defect (fixed)

sip_copy_proc.c:333:45: error: use of undeclared identifier 'O_CLOEXEC'

Reported by: ryandesign (Ryan Schmidt) Owned by: neverpanic (Clemens Lang)
Priority: Normal Milestone:
Component: base Version: 2.3.99
Keywords: Cc: nerdling (Jeremy Lavergne)
Port:

Description

https://build.macports.org/builders/buildbase-snowleopard-x86_64/builds/1849

sip_copy_proc.c:119:53: warning: unused parameter 'path' [-Wunused-parameter]
static copy_needed_return_t copy_needed(const char *path, char *const argv[],
                                                    ^
sip_copy_proc.c:119:71: warning: unused parameter 'argv' [-Wunused-parameter]
static copy_needed_return_t copy_needed(const char *path, char *const argv[],
                                                                      ^
sip_copy_proc.c:120:16: warning: unused parameter 'outargv' [-Wunused-parameter]
        char **outargv[], char *const environ[], struct stat *st) {
               ^
sip_copy_proc.c:120:39: warning: unused parameter 'environ' [-Wunused-parameter]
        char **outargv[], char *const environ[], struct stat *st) {
                                      ^
sip_copy_proc.c:120:63: warning: unused parameter 'st' [-Wunused-parameter]
        char **outargv[], char *const environ[], struct stat *st) {
                                                              ^
sip_copy_proc.c:333:45: error: use of undeclared identifier 'O_CLOEXEC'
    if (-1 == (infd = open(path, O_RDONLY | O_CLOEXEC))) {
                                            ^
sip_copy_proc.c:349:33: error: use of undeclared identifier 'buf'
        bytes_read = read(infd, buf, in_st->st_blksize);
                                ^
sip_copy_proc.c:365:44: error: use of undeclared identifier 'buf'
            ssize_t written = write(outfd, buf + bytes_written, bytes_read - bytes_written);
                                           ^
5 warnings and 3 errors generated.
make[2]: *** [sip_copy_proc.o] Error 1

Attachments (1)

patch-src-pextlib1.0-sip_copy_proc.c.diff (654 bytes) - added by nerdling (Jeremy Lavergne) 7 years ago.
r142960

Download all attachments as: .zip

Change History (3)

comment:1 Changed 7 years ago by nerdling (Jeremy Lavergne)

Cc: snc@… added

Cc Me!

Changed 7 years ago by nerdling (Jeremy Lavergne)

comment:2 Changed 7 years ago by nerdling (Jeremy Lavergne)

Resolution: fixed
Status: newclosed

10.6 and earlier do not have O_CLOEXEC (close on exec) defined. I've committed r142960, which simply skips that file creation flag.

Last edited 7 years ago by nerdling (Jeremy Lavergne) (previous) (diff)
Note: See TracTickets for help on using tickets.