cctools @877.5 fails to _install_ on PPC Mac OS X 10.5.8, Leopard, because of permissions

[ballapete (Peter "Pete" Dyballa)]

The build went fine, it's only some finishing script that fails because of permissions

DEBUG: No need to upgrade! llvm_select 1.0_0 >= llvm_select 1.0_0
DEBUG: changing euid/egid - current euid: 0 - current egid: 0
DEBUG: egid changed to: 502
DEBUG: euid changed to: 502
DEBUG: couldn't open "/opt/local/var/macports/build/_opt_mports_trunk_dports_devel_cctools/cctools/work/.macports.cctools.state": permission denied
    while executing
"open $statefile a+"
    (procedure "open_statefile" line 124)
    invoked from within
"open_statefile"
    (procedure "check_variants" line 29)
    invoked from within
"check_variants install"
    invoked from within
"$workername eval check_variants $target"
    (procedure "mportexec" line 7)
    invoked from within
"mportexec $mport install"
Error: Follow http://guide.macports.org/#project.tickets to report a bug.
DEBUG: Checking time since last reclaim run

[ryandesign (Ryan Carsten Schmidt)]

Please ​clean cctools and try again and attach the main.log if it fails again.

[ballapete (Peter "Pete" Dyballa)]

Replying to ryandesign@…:

Please ​clean cctools and try again and attach the main.log if it fails again.

[ballapete (Peter "Pete" Dyballa)]

Replying to ryandesign@…:

The new build went fine…

[ballapete (Peter "Pete" Dyballa)]

On PPC Tiger, Mac OS X 10.4.11, I got the error!

[ballapete (Peter "Pete" Dyballa)]

main.log on PPC Tiger

[ballapete (Peter "Pete" Dyballa)]

Replying to Peter_Dyballa@…:

On PPC Tiger, Mac OS X 10.4.11, I got the error!

Arrgh! It's a different error (for the moment):

:info:build libtool.c: In function 'save_lto_member_toc_info':
:info:build libtool.c:3847: error: 'struct member' has no member named 'lto_toc_nsyms'
:info:build libtool.c:3848: warning: implicit declaration of function 'lto_get_nsyms'
:info:build libtool.c:3850: warning: implicit declaration of function 'lto_toc_symbol'
:info:build libtool.c:3851: error: 'struct member' has no member named 'lto_toc_nsyms'
:info:build libtool.c:3852: error: 'struct member' has no member named 'lto_toc_strsize'
:info:build libtool.c:3852: warning: implicit declaration of function 'lto_symbol_name'
:info:build libtool.c:3852: warning: passing argument 1 of 'strlen' makes pointer from integer without a cast
:info:build libtool.c:3855: error: 'struct member' has no member named 'lto_toc_strings'
:info:build libtool.c:3855: error: 'struct member' has no member named 'lto_toc_strsize'
:info:build libtool.c:3856: error: 'struct member' has no member named 'lto_toc_strings'
:info:build libtool.c:3859: warning: passing argument 2 of 'strcpy' makes pointer from integer without a cast
:info:build libtool.c:3860: warning: passing argument 1 of 'strlen' makes pointer from integer without a cast
:info:build make[1]: *** [libtool.o] Error 1

[ballapete (Peter "Pete" Dyballa)]

The missing member is contained herein:

#ifdef LTO_SUPPORT
    enum bool lto_contents;	    /* TRUE if this member has lto contents */
    uint32_t lto_toc_nsyms;	    /* number of symbols for the toc */
    uint32_t lto_toc_strsize;	    /* the size of the strings for the toc */
    char *lto_toc_strings;	    /* the strings of the symbols for the toc */
#endif /* LTO_SUPPORT */

[ballapete (Peter "Pete" Dyballa)]

Could be the function save_lto_member_toc_info() needs to be put into ifdef LTO_SUPPORT/#endif…

It's only used in one source file:

misc/libtool.c:266:static void save_lto_member_toc_info(
misc/libtool.c:2183:	    save_lto_member_toc_info(member, ofile->lto);
misc/libtool.c:2196:	    save_lto_member_toc_info(member, ofile->lto);
misc/libtool.c:2208:	        save_lto_member_toc_info(member, ofile->lto);
misc/libtool.c:3833: * save_lto_member_toc_info() saves away the table of contents info for a
misc/libtool.c:3840:save_lto_member_toc_info(

[jeremyhu (Jeremy Huddleston Sequoia)]

Replying to Peter_Dyballa@…:

Could be the function save_lto_member_toc_info() needs to be put into ifdef LTO_SUPPORT/#endif…

Yes. Could you please provide a patch?

[ballapete (Peter "Pete" Dyballa)]

Replying to jeremyhu@…:

Replying to Peter_Dyballa@…:

Could be the function save_lto_member_toc_info() needs to be put into ifdef LTO_SUPPORT/#endif…

Yes. Could you please provide a patch?

I put all occurrences of the use of the lto member into guards. There are some more files that use them:

cctools-877.5/include/stuff/breakout.h
cctools-877.5/include/stuff/lto.h
cctools-877.5/include/stuff/ofile.h
cctools-877.5/libstuff/Makefile
cctools-877.5/libstuff/breakout.c
cctools-877.5/libstuff/llvm.c
cctools-877.5/libstuff/lto.c
cctools-877.5/libstuff/ofile.c
cctools-877.5/libstuff/writeout.c
cctools-877.5/misc/libtool.c
cctools-877.5/misc/lipo.c
cctools-877.5/misc/nm.c
cctools-877.5/otool/main.c

Cctools built on PPC Tiger, Mac OS X 10.4.11.

[ballapete (Peter "Pete" Dyballa)]

The mentioned patch for Tiger

[drennanelawar (Daniel Drennan ElAwar)]

cctools log for 10.6.8 Snow Leopard

[drennanelawar (Daniel Drennan ElAwar)]

cctools fails on Snow Leopard 10.6.8; a different issue I think. I attached the log file. Thank you.

[ballapete (Peter "Pete" Dyballa)]

Replying to drennan@…:

cctools fails on Snow Leopard 10.6.8; a different issue I think. I attached the log file. Thank you.

The errors are exactly the same.

[drennanelawar (Daniel Drennan ElAwar)]

Cc Me!

[drennanelawar (Daniel Drennan ElAwar)]

Patched and built. Thanks.

[jeremyhu (Jeremy Huddleston Sequoia)]

Thanks, pushed in r143913.