giflib: update to 5.1.4

[ryandesign (Ryan Carsten Schmidt)]

#35817 explains why I did not upgrade giflib to version 5.x, last time I looked into the situation. If the situation has changed, please let me know.

[ryandesign (Ryan Carsten Schmidt)]

Maybe it's time to revisit this.

The latest version of giflib is now 5.1.4.

Just checking a few of the dependents, ​leptonica, ​kdelibs4, ​libgdiplus, ​webp, and imlib2 have had giflib 5 support for years. leptonica is now considering ​dropping support for giflib < 5.1.

There are currently 68 ports that depend on giflib, including some rather old ones like qt4-x11 that probably don't support giflib 5. If we update giflib to version 5, we probably need to make a giflib4 port for compatibility with those old ports.

[ryandesign (Ryan Carsten Schmidt)]

A ​PR was submitted but it was incomplete and closed for lack of activity.

[Schamschula (Marius Schamschula)]

I just ran into this issue while trying to create a Portfile for py-imagecodecs. giflib 4.x causes errors like

imagecodecs/_gif.c:3032:54: error: too many arguments to function call, expected 0, have 1
      __pyx_v_errormessage = ((char *)GifErrorString(__pyx_v_errorcode));
                                      ~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~
/opt/local/include/gif_lib.h:203:1: note: 'GifErrorString' declared here
extern char *GifErrorString(void);     /* new in 2012 - ESR */
^

while giflib 5.2.1 builds the gif support cleanly.

[ryandesign (Ryan Carsten Schmidt)]

A giflib5 port has been available for years now.