Opened 8 years ago

Closed 6 years ago

#50066 closed defect (fixed)

root6 +python34: tmva/pymva/src/MethodPyAdaBoost.cxx:178:22: error: use of undeclared identifier 'PyString_FromString'

Reported by: watsodw Owned by: cjones051073 (Chris Jones)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: mojca (Mojca Miklavec), hapaguy (Brian Kurt Fujikawa)
Port: root6

Description (last modified by mojca (Mojca Miklavec))

Error causes by some TMVA issue? See log.

:info:build [100%] Building CXX object tmva/tmvagui/CMakeFiles/TMVAGui.dir/src/correlationscattersMultiClass.cxx.o
:info:build cd /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root6/root6/work/build/tmva/tmvagui && /opt/local/bin/lang++-mp-3.7   -DTMVAGui_EXPORTS -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root6/root6/work/build/include/root -I/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root6/root6/work/build/include  -pipe -Os -arch x86_64 -stdlib=libc++  -m64 -pipe -W -Wall -Woverloaded-virtual -fsigned-char -fno-common -Qunused-arguments -pthread -std=c++11 -Wno-deprecated-declarations -Wc++11-narrowing -Wsign-compare -Wsometimes-uninitialized -Wconditional-uninitialized -Wheader-guard -Warray-bounds -Wcomment -Wtautological-compare -Wstrncat-size -Wloop-analysis -Wbool-conversion -stdlib=libc++ -DR__HAVE_CONFIG -O2 -DNDEBUG -arch x86_64 -fPIC   -o CMakeFiles/TMVAGui.dir/src/correlationscattersMultiClass.cxx.o -c /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root6/root6/work/root-6-06-00/tmva/tmvagui/src/correlationscattersMultiClass.cxx
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root6/root6/work/root-6-06-00/tmva/pymva/src/MethodPyAdaBoost.cxx:178:22: error: use of undeclared identifier 'PyString_FromString'
:info:build    PyObject *pName = PyString_FromString("sklearn.ensemble");
:info:build                      ^
:info:build /opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_science_root6/root6/work/root-6-06-00/tmva/pymva/src/MethodPyAdaBoost.cxx:264:14: error: use of undeclared identifier 'PyString_AsString'
:info:build    PyData << PyString_AsString(model_data);
:info:build              ^
:info:build 2 errors generated.
:info:build make[2]: *** [tmva/pymva/CMakeFiles/PyMVA.dir/src/MethodPyAdaBoost.cxx.o] Error 1
:info:build make[2]: *** Waiting for unfinished jobs....

Variants:

root6-6.06.00_0+clang37+cocoa+fftw3+fitsio+gcc5+graphviz+gsl+http+minuit2+opengl+pythia+python34+roofit+soversion+ssl+tmva+xml+xrootd.darwin_13.x86_64

Attachments (1)

main.log (9.2 MB) - added by watsodw 8 years ago.

Change History (9)

Changed 8 years ago by watsodw

Attachment: main.log added

comment:1 Changed 8 years ago by mojca (Mojca Miklavec)

Cc: jonesc@… removed
Description: modified (diff)
Owner: changed from macports-tickets@… to jonesc@…
Version: 2.3.4

comment:2 Changed 8 years ago by mojca (Mojca Miklavec)

Summary: root6 upgrade/install failsroot6 +python34: tmva/pymva/src/MethodPyAdaBoost.cxx:178:22: error: use of undeclared identifier 'PyString_FromString'

This looks very similar to #44312. See the upstream report:

comment:3 Changed 8 years ago by cjones051073 (Chris Jones)

ROOT's support for Python 3.x is very patchy. Read never tested... It comes and goes...

Unless you have a really strong need for python 3.x, in which case you need to take it up with the upstream ROOT devs, I recommend using the default python variant, 2.7.

comment:4 Changed 8 years ago by mojca (Mojca Miklavec)

The upstream claims to have fixed the problem in master. See the following commit for example. But I don't see the patches in the 6.06 branch. Is anyone willing to test both (master & the latest commit in the 6.06 branch)? Maybe we should make an explicit request to fix the files also in that branch.

comment:5 Changed 8 years ago by cjones051073 (Chris Jones)

We should request the fix to be pulled into the 6.06 branch as well. I guess the place to it is in

https://sft.its.cern.ch/jira/browse/ROOT-7824

will you post a comment there ?

cheers Chris

comment:6 Changed 8 years ago by hapaguy (Brian Kurt Fujikawa)

Cc: brian.fujikawa@… added

Cc Me!

comment:7 Changed 6 years ago by cjones051073 (Chris Jones)

Python 3 should be fully supported now, so closing this old ticket. Please start a new one if the problem persists with up to date ports.

comment:8 Changed 6 years ago by cjones051073 (Chris Jones)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.