Opened 8 years ago

Closed 8 years ago

#50488 closed enhancement (fixed)

gflags: also build shared libs

Reported by: carlesfernandez (Carles Fernandez) Owned by: c9s@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: haspatch Cc: ryandesign (Ryan Carsten Schmidt), kurthindenburg (Kurt Hindenburg)
Port: gflags

Description

Gflags 2.1.2 does not build libgflags.dylib by default; the flag -DBUILD_SHARED_LIBS=ON should be passed to CMake. I'm attaching a patch that builds both the static and shared versions.

Attachments (1)

add_shared_lib.patch​ (711 bytes) - added by carlesfernandez (Carles Fernandez) 8 years ago.
Portfile patch

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)

Cc: ryandesign@… added; c9s@… removed
Keywords: haspatch added; shared libs removed
Owner: changed from macports-tickets@… to c9s@…
Summary: Adding shared lib building in gflags port → gflags: also build shared libs

Thanks. The revision line should go right after the github.setup line.

comment:2 in reply to:  1 Changed 8 years ago by carlesfernandez (Carles Fernandez)

Replying to ryandesign@…:

Thanks. The revision line should go right after the github.setup line.

Thanks. This new patch fixes the issue.

Changed 8 years ago by carlesfernandez (Carles Fernandez)

Attachment: add_shared_lib.patch​ added

Portfile patch

comment:3 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:4 Changed 8 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: → fixed
Status: new → closed

done r145448

Note: See TracTickets for help on using tickets.