Opened 8 years ago
Closed 8 years ago
#50580 closed submission (fixed)
edmv 0.1.0 new port
| Reported by: | casey (Casey Rodarmor) | Owned by: | Ionic (Mihai Moldovan) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | Cc: | ||
| Port: | edmv |
Description
New port for interactive file renamer edmv
Attachments (1)
Change History (13)
comment:1 Changed 8 years ago by casey (Casey Rodarmor)
| Cc: | casey@… added |
|---|
comment:2 Changed 8 years ago by mf2k (Frank Schima)
| Cc: | casey@… removed |
|---|---|
| Version: | 2.3.4 |
comment:3 follow-up: 4 Changed 8 years ago by Ionic (Mihai Moldovan)
| Owner: | changed from macports-tickets@… to ionic@… |
|---|---|
| Status: | new → assigned |
Please consider replacing the /usr/bin/env python hashbang with a MacPorts-provided intepreter and adding appropriate dependencies.
comment:4 Changed 8 years ago by casey (Casey Rodarmor)
Replying to ionic@…:
Please consider replacing the
/usr/bin/env pythonhashbang with a MacPorts-provided intepreter and adding appropriate dependencies.
I like that suggestion, but I would like to keep the program runnable on systems that don't use macports, and this would require a macports specific patch.
comment:5 follow-up: 6 Changed 8 years ago by Ionic (Mihai Moldovan)
No need to! You can do you this in the post-patch { ... } phase using the reinplace command.
comment:6 Changed 8 years ago by casey (Casey Rodarmor)
Replying to ionic@…:
No need to! You can do you this in the
post-patch { ... }phase using thereinplacecommand.
Sweet, sounds good.
This script should be compatible with most recent versions of python 2 and all versions of python 3. Given that, which macports-provided version of python should I depend on? Maybe 3.5 because it's the most recent?
comment:7 Changed 8 years ago by casey (Casey Rodarmor)
Okay, the updated portfile now uses macports provided python35.
comment:8 Changed 8 years ago by Ionic (Mihai Moldovan)
Nice!
You "only" need to:
- include the
python 1.0PortGroup categories-append python- set
python.default_versionto35 - depend on any additional
py${python.version}-...modules not part of the core, if neccessary - replace
file copywithxinstall -m 0755 - delete the explicit
pythondependency
comment:10 Changed 8 years ago by Ionic (Mihai Moldovan)
Great, thanks.
I'd commit it into the sysutils main category with two minor changes:
- replace
categories-append sysutilswithcategories sysutils python - change the indentation so that it's actually a multiple of 4 as advertised in the mode line
No need to tweak your own Portfile and re-upload it for that, just tell me if you're okay with the proposed changes.
comment:12 Changed 8 years ago by Ionic (Mihai Moldovan)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Cc Me!