Opened 8 years ago

Closed 8 years ago

#50901 closed defect (fixed)

realpath @1.0.0 binary and man page are not installed in the proper location

Reported by: user454322 (Javier) Owned by: user454322 (Javier)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc:
Port: realpath

Description

The changes in https://github.com/user454322/realpath/commit/63813bbc61eee89855b3b71c056272c9fdc87315 impact the way realpath is installed via MacPorts. It would result on a failed installation.

The attached patch to dports/sysutils/realpath/Portfile should fix it.

Attachments (3)

p.patch (418 bytes) - added by user454322 (Javier) 8 years ago.
typescript (4.0 KB) - added by user454322 (Javier) 8 years ago.
testing from command line
realpath-1.0.1.patch (1.1 KB) - added by user454322 (Javier) 8 years ago.
Patch to update to version 1.0.1

Download all attachments as: .zip

Change History (12)

Changed 8 years ago by user454322 (Javier)

Attachment: p.patch added

comment:1 Changed 8 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to dev.modprobe@…

In the future, please Cc the port maintainers (port info --maintainers realpath), if any.

comment:2 Changed 8 years ago by user454322 (Javier)

Hi,

I'm the owner of the project in GitHub, made the changes described above but I don't have commit rights. What is the best way to get this patch applied? Should I apply for commit privileges or can someone who already has commit privileges update the port?

Thanks in advance

comment:3 Changed 8 years ago by mf2k (Frank Schima)

So you are also using the email address dev.modprobe? Please either change the maintainer email in the Portfile or your Trac email so they match and we know that you are maintainer when submitting patches.

comment:4 Changed 8 years ago by user454322 (Javier)

Thanks.

I have updated my email address to match the one specified in the port.

What would be the next step?

=)

comment:5 Changed 8 years ago by mf2k (Frank Schima)

Before this patch, the port installed without problem for me.

After applying this patch, I see the following warning/error:

--->  Staging realpath into destroot
Warning: violation by /opt/local/realpath
Warning: realpath violates the layout of the ports-filesystems!
Warning: Please fix or indicate this misbehavior (if it is intended), it will be an error in future releases!
Last edited 8 years ago by mf2k (Frank Schima) (previous) (diff)

comment:6 Changed 8 years ago by user454322 (Javier)

Sorry, the previous patch doesn't play well with the 1.0.0 version. Since there have been some changes, I created a new release, i.e., 1.0.1.

I created a patch to update the version in MacPorts (realpath-1.0.1.patch).

I tested it on my environment and seems to be working fine (typescript).

Please let me know if there are more issues or things that can be improved.

Changed 8 years ago by user454322 (Javier)

Attachment: typescript added

testing from command line

comment:7 Changed 8 years ago by mf2k (Frank Schima)

Please instead attach patch based on the original Portfile from svn.

comment:8 Changed 8 years ago by user454322 (Javier)

Hi, I'm attaching a patch based on the original Portfile from svn.

Let me know if there are more changes that need to be made.

Thanks =)

Changed 8 years ago by user454322 (Javier)

Attachment: realpath-1.0.1.patch added

Patch to update to version 1.0.1

comment:9 Changed 8 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.