#51056 closed enhancement (fixed)
pure 0.64 update
| Reported by: | agraef (Albert Graef) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch maintainer | Cc: | |
| Port: | pure |
Description
Minor update (bump to revision 3) which adds a patch that fixes an issue with Pure running as a VST plug-in.
Attachments (2)
Change History (8)
Changed 8 years ago by agraef (Albert Graef)
| Attachment: | pure-Portfile.diff added |
|---|
Changed 8 years ago by agraef (Albert Graef)
| Attachment: | pure-0.64-runtime-hotfix.diff added |
|---|
comment:1 Changed 8 years ago by mf2k (Frank Schima)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Type: | update → enhancement |
| Version: | 2.3.4 |
comment:2 follow-up: 4 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
| Status: | new → assigned |
|---|
comment:3 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed without the removal of port:ncurses in r148006.
comment:4 Changed 8 years ago by agraef (Albert Graef)
Replying to ryandesign@…:
Thanks. Your patch also removes the
port:ncursesdependency, but I think that needs to stay, because pure and libpure.dylib do link with libncurses.dylib.
ncurses is needed only for readline (which has it as a dependency), so the dependency shouldn't actually be needed. But it doesn't hurt either.
comment:5 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
pure links with libncurses, therefore it needs the dependency declared. We use the list of declared dependencies to find ports that need to have their revisions increased to rebuild them after a dependency's library version number has been increased. This happened for example when ncurses' library version increased from 5 to 6 in 2015; pure was broken until its revision was increased in r140525, and to remind us that this needs to happen anytime ncurses' library version changes again in the future, I also added the ncurses dependency at that time.
If pure linking with libncurses is unnecessary, and only caused by readline, then that would be a bug we should report against readline. I agree that ports that link with readline do also link with ncurses, but I do not know whether that linkage is unnecessary.
comment:6 Changed 8 years ago by agraef (Albert Graef)
Ok, I understand. I don't recall why exactly linking against ncurses is necessary, probably has something to do with the fact that readline can work with a number of different underlying terminal interfaces. Anyway, let's just keep the ncurses dependency then, I don't see this as an issue.
Thanks. Your patch also removes the
port:ncursesdependency, but I think that needs to stay, because pure and libpure.dylib do link with libncurses.dylib.