Opened 3 years ago

Closed 3 years ago

#51060 closed enhancement (fixed)

nghttp2 @1.9.2_0: add python35 variant

Reported by: Schamschula (Marius Schamschula) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: haspatch maintainer Cc: kurthindenburg (Kurt Hindenburg)
Port: nghttp2

Description

I've added a python35 variant to nghttp2, while setting python27 as the default variant.

Unfortunately, the python versions have to be manually set as there are some issues related to using variables to set PythonVersion and PythonBranch for the various phases of the installation process, particularly destroot.

No revision bump, as the default variant remains the same.

Attachments (1)

Portfile-nghttp2.diff (2.3 KB) - added by Schamschula (Marius Schamschula) 3 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by Schamschula (Marius Schamschula)

The second version: using if {[variant_isset foo]} { set bar xyz } to set PythonVersion, rather than inside the variant blocks. This is what it should have looked like all along.

comment:2 Changed 3 years ago by Schamschula (Marius Schamschula)

Dealt with the situation where a user might not want python at all.

comment:3 Changed 3 years ago by Schamschula (Marius Schamschula)

Removed unneeded line continuation character.

comment:4 Changed 3 years ago by Schamschula (Marius Schamschula)

Reverted to disallowing install w/o python, as nghttp2 otherwise uses the system's python 2.7.

Now we throw an error if no version of python is selected.

Changed 3 years ago by Schamschula (Marius Schamschula)

Attachment: Portfile-nghttp2.diff added

comment:5 Changed 3 years ago by Schamschula (Marius Schamschula)

Reordered blocks to conventional order.

comment:6 Changed 3 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

In r147493, thanks.

Note: See TracTickets for help on using tickets.