Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#51222 closed update (fixed)

nfft-3 @3.3.1 Update Portfile for new release.

Reported by: macports@… Owned by: jenskeiner (Jens Keiner)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: kurthindenburg (Kurt Hindenburg), dstrubbe (David Strubbe)
Port: nfft-3

Description

This is to update the Portfile for the port nfft-3 to the latest release 3.3.1.

Attachments (2)

Portfile (3.1 KB) - added by macports@… 3 years ago.
Updated Portfile
Portfile.2 (3.1 KB) - added by jenskeiner (Jens Keiner) 3 years ago.
Updated Portfile

Download all attachments as: .zip

Change History (14)

comment:1 Changed 3 years ago by macports@…

The Portfile now also specifies the (optional) test phase which will run the provided unit tests.

comment:2 Changed 3 years ago by mf2k (Frank Schima)

Owner: changed from macports-tickets@… to jens@…
Version: 2.3.4

Thanks. Per the guidelines, please instead attach a unified diff of the Portfile so we can easily see what changes you are proposing.

In the future, please Cc the port maintainers (port info --maintainers nfft-3), if any.

Changed 3 years ago by macports@…

Attachment: Portfile added

Updated Portfile

comment:3 Changed 3 years ago by macports@…

Thanks for the information. I am the maintainer of this port, though I'm using a different email address in this ticketing system. Here's the diff output when comparing to the current version:

8c8
< version             3.3.0
---
> version             3.3.1
39,41c39,41
< master_sites        https://www-user.tu-chemnitz.de/~potts/nfft/download/
< checksums           rmd160 52cac61a90a72bb25a91b3aa0d1b1692d1895e26 \
<                     sha256 bb844b762896b17b7bf8245511a6372fcef82e55c2552f2f7ee7c65a8d746f30
---
> master_sites        https://github.com/NFFT/nfft/releases/download/${version}/
> checksums           rmd160 08b4ff6b8d35b2ebc90159a8e86ff400e565528c \
>                     sha256 74cc7f4c8922d72131c59f88ecb542e06254eaded09018d6367f8a46c0fb3125
49a50,52
> test.run yes
> test.target check
> 

In essence, the version number has been bumped, the download location has been updated (assets are now provided directly on GitHub), and the optional test target has been added.

comment:4 Changed 3 years ago by mf2k (Frank Schima)

Then you should either change your trac email to match the portfile or vice versa. Otherwise we have no idea that the maintainer is attaching a patch.

Also, please instead use the github portgroup.

Changed 3 years ago by jenskeiner (Jens Keiner)

Attachment: Portfile.2 added

Updated Portfile

comment:5 Changed 3 years ago by jenskeiner (Jens Keiner)

G'day,

I have updated the Portfile to use the PortGroup github. I have also changed my user's email address to match the one in the Portfile. The dependency is a bit awkward since I would be forced to create a separate account if a different maintainer email would be used for another port maintained by myself.

Best,

Jens

comment:6 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:7 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

Normally, you would upload a diff - I went ahead and cleaned up the Portfile a bit r148677

comment:8 Changed 3 years ago by dstrubbe (David Strubbe)

Why did you remove the use of the compilers portgroup? There is no mention of that change in this discussion or the resulting commit.

comment:9 Changed 3 years ago by dstrubbe (David Strubbe)

Cc: dstrubbe@… added

Cc Me!

comment:10 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

Perhaps Jens accidently removed it - should I re-add it?

comment:11 Changed 3 years ago by dstrubbe (David Strubbe)

Yes it looks like that might have been a mistake. I think it is helpful to use the compilers portgroup, since for scientific/mathematical ports like this, one might wish to try different compilers to find the best performance, so I think it should be re-added.

comment:12 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

done r148786

Note: See TracTickets for help on using tickets.