Quassel Version Bump

[wintermute_77@…]

Quassel and quassel-client verison is 0.12.4.

[wintermute_77@…]

PortSystem 1.0
PortGroup cmake 1.0
PortGroup cxx11 1.0
PortGroup qt4 1.0

name            quassel
version         0.12.4
revision        0
categories      irc
license         GPL-2 GPL-3
platforms       darwin
maintainers     nomaintainer
homepage        http://quassel-irc.org
master_sites    ${homepage}/pub

checksums       rmd160  f7282c07716342b235ab506722c17675854569fb \
                sha256  93e4e54cb3743cbe2e5684c2fcba94fd2bc2cd739f7672dee14341b49c29444d

depends_lib-append \
                port:dbusmenu-qt \
                path:lib/libssl.dylib:openssl \
                port:phonon \
                port:zlib

use_bzip2       yes

cmake.out_of_source yes

configure.args  -DWANT_CORE=OFF \
                -DWANT_QTCLIENT=OFF \
                -DWANT_MONO=OFF \
                -DWITH_KDE=OFF

if {${name} eq ${subport}} {
    description \
        Qt4 IRC client
    long_description \
        Quassel IRC is a modern, cross-platform IRC client. This port installs \
        the monolithic variant, which does not require a separate Quassel core.

    depends_run-append port:qt4-mac-sqlite3-plugin

    configure.args-replace -DWANT_MONO=OFF -DWANT_MONO=ON

    destroot {
        copy "${build.dir}/Quassel.app" "${destroot}${applications_dir}"
    }
}

subport ${name}-client {
    description \
        Qt4 IRC client - client component
    long_description \
        Quassel IRC is a modern, cross-platform, distributed IRC client, \
        meaning that one (or multiple) client(s) can attach to and detach from \
        a central core - much like the popular combination of screen and a \
        text-based IRC client such as WeeChat, but graphical.

    depends_run-append port:qca-ossl

    configure.args-replace -DWANT_QTCLIENT=OFF -DWANT_QTCLIENT=ON

    destroot {
        copy "${build.dir}/Quassel Client.app" "${destroot}${applications_dir}"
    }
}

livecheck.type  regex
livecheck.url   http://quassel-irc.org/pub/
livecheck.regex "${name}-(\[0-9\.\]+)\.tar\.bz2"

[neverpanic (Clemens Lang)]

Here's a unified diff of the changes, which we usually want instead of the updated Portfile because it makes reviewing the changes easier:

Portfile

@@ -7 +7 @@
 PortGroup qt4 1.0
 
 name            quassel
-version         0.12.2
-revision        3
+version         0.12.4
+revision        0
 categories      irc
 license         GPL-2 GPL-3
 platforms       darwin
@@ -16 +16 @@
 homepage        http://quassel-irc.org
 master_sites    ${homepage}/pub
 
-checksums       rmd160  d729c689028b111774dd31d1b2daf7ea8cda2aca \
-                sha256  6bd6f79ecb88fb857bea7e89c767a3bd0f413ff01bae9298dd2e563478947897
+checksums       rmd160  f7282c07716342b235ab506722c17675854569fb \
+                sha256  93e4e54cb3743cbe2e5684c2fcba94fd2bc2cd739f7672dee14341b49c29444d
 
 depends_lib-append \
                 port:dbusmenu-qt \
@@ -27 +27 @@
 
 use_bzip2       yes
 
-# Do not use git to find out the program version - there is no ".git" directory
-# in the source tarball
-patchfiles      patch-scripts-build-macosx_makebundle.py.diff \
-                patch-render.diff
-
-post-patch {
-    reinplace "s|@@VERSION@@|${version}|" \
-        ${worksrcpath}/scripts/build/macosx_makebundle.py
-}
-
 cmake.out_of_source yes
 
 configure.args  -DWANT_CORE=OFF \

Any reason why you're dropping the patches? The patch-scripts-build-macosx_makebundle.py.diff still seems to be necessary because we're not building from a git checkout. The change to src/common/main.cpp in patch-render.diff was related to retina displays IIRC, see r126718.

[wintermute_77@…]

I just did what was quick and dirty to get it to build. One of the patches wasn't working, so I just removed them. If they are needed or improve things, definitely put them back in.

[wintermute_77@…]

Patch to Portfile

[wintermute_77@…]

Patch to bundling patch.

[neverpanic (Clemens Lang)]

Committed in r149583. Unfortunately Quassel doesn't look as nice on High-DPI displays as I would have wanted to. Maybe this can be fixed by moving to Qt5, since the official binary doesn't seem to have the problem.

[neverpanic (Clemens Lang)]

Indeed, Qt5 seems to deal much better with HiDPI displays. Caveats apply because we don't have a lot of Qt5 dependencies of Quassel yet. See the commit message of r149653.