p5.24-scope-upper: error: use of undeclared identifier 'CXt_LOOP_FOR'

[mojca (Mojca Miklavec)]

p5.24-scope-upper is broken since 5.23.8:

"/opt/local/bin/perl5.24" "/opt/local/lib/perl5/5.24/ExtUtils/xsubpp"  -typemap "/opt/local/lib/perl5/5.24/ExtUtils/typemap"  Upper.xs > Upper.xsc && mv Upper.xsc Upper.c
cp lib/Scope/Upper.pm blib/lib/Scope/Upper.pm
/usr/bin/clang -c   -fno-common -DPERL_DARWIN -mmacosx-version-min=10.7 -pipe -Os -fno-strict-aliasing -fstack-protector -I/opt/local/include -DPERL_USE_SAFE_PUTENV -arch x86_64 -O3   -DVERSION=\"0.28\" -DXS_VERSION=\"0.28\"  "-I/opt/local/lib/perl5/5.24/darwin-thread-multi-2level/CORE"  -DSU_RELEASE=1 Upper.c
Upper.xs:1331:11: error: use of undeclared identifier 'CXt_LOOP_FOR'
     case CXt_LOOP_FOR:
          ^
Upper.xs:1372:8: error: use of undeclared identifier 'CXt_LOOP_FOR'
  case CXt_LOOP_FOR:
       ^
Upper.xs:1543:31: error: no member named 'argarray' in 'struct block_sub'
       argarray = cx->blk_sub.argarray;
                  ~~~~~~~~~~~ ^
Upper.xs:1618:29: error: no member named 'argarray' in 'struct block_sub'
   SvREFCNT_dec(cx->blk_sub.argarray);
                ~~~~~~~~~~~ ^
...

Upstream report: ​https://rt.cpan.org/Public/Bug/Display.html?id=112246

[dbevans (David B. Evans)]

Based on the upstream report, the required modifications are extensive and not well agreed upon by the developers. May be a while before this is fixed.

In MacPorts, only p5-dancer2 depends on this port and it's only recommended at runtime, not required. Dependency removed for now in r148594 to allow p5.24-dancer2 to build. Tests are uneffected.

[mojca (Mojca Miklavec)]

A bonus question would be whether we need this port in MacPorts at all. We could remove it and only add it back when someone requests it.

[dbevans (David B. Evans)]

I'd expect that with 5.24 released there will be some pressure to get this fixed/reworked. I think I'd just leave it alone for now and monitor upstream activity. Maybe even give a little push.

[dbevans (David B. Evans)]

Note that p5.22-scope-upper builds fine and is the current default subport.

[dbevans (David B. Evans)]

Fixed by upgrade to version 0.29 in r149698.