Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#51481 closed update (fixed)

libicns: update to 0.8.1

Reported by: dardo82 (Michele Venturi) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: libicns

Description

This version implement 1024x1024 support.
https://sourceforge.net/p/icns/news/

I'm going to take maintainership of this port,
but i've never done this before on MacPorts,
so if i manage, it will surely take same time...
MicheleVenturi-dardo82@…

Attachments (1)

update-libicns.diff (3.4 KB) - added by dardo82 (Michele Venturi) 4 years ago.
My first PortFile patch! 8-)

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by dardo82 (Michele Venturi)

Attachment: update-libicns.diff added

My first PortFile patch! 8-)

comment:1 Changed 4 years ago by dardo82 (Michele Venturi)

If i have done it right, it took less time than i feared... _

comment:2 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Cc Me!

comment:3 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Cc: nomaintainer@… removed
Keywords: patch added; lib icns rsrc png removed
Version: 2.3.4

OK thanks - not too bad a first attempt :-) - please try to not include whitespace/tab changes with actual changes - it makes it too hard to tell what's going on.

Also, if we're using github now, we should use the 'PortGroup github 1.0'

If you want to try again, go ahead - I may get around to helping you out in the next few days

comment:4 in reply to:  3 Changed 4 years ago by mf2k (Frank Schima)

@khindenburg: FYI we do not have a "patch" keyword. We do have a "haspatch" keyword however.

comment:5 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Keywords: haspatch added; patch removed

comment:6 Changed 4 years ago by dardo82 (Michele Venturi)

I am on GitHub as https://github.com/dardo82/.
I have just found your organization on GitHub,
but there are no repositories at the moment...
I also think that the patch is no more needed.
So, what should I do now?

Last edited 4 years ago by dardo82 (Michele Venturi) (previous) (diff)

comment:7 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Resolution: fixed
Status: newclosed

Dardo, I went ahead and fix this r149039 r149040 - this was likely a hard example to start out with.

Some notes:

  1. no reason to use https://github.com/pornel/libicns/ since they haven't tagged any release.
  2. You can see I first fix the whitespace issues and then committed the functional changes.

You can read the guide for more info

https://guide.macports.org/#project.contributing

comment:8 in reply to:  7 Changed 4 years ago by dardo82 (Michele Venturi)

As long as it's fixed, I'm happy with it. :-)
Starting with simple things is not funny! :-P
It didn't even took so long to get it done...

Last edited 4 years ago by dardo82 (Michele Venturi) (previous) (diff)
Note: See TracTickets for help on using tickets.