Opened 4 years ago

Closed 4 years ago

#51626 closed submission (fixed)

ldas-tools-al

Reported by: emaros Owned by: skymoo (Adam Mercer)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: ryandesign (Ryan Schmidt)
Port: ldas-tools-al

Description

This is the first package broken out of ldas-tools

Attachments (2)

Portfile (2.4 KB) - added by emaros 4 years ago.
Portfile-ldas-tools-al.diff (1.4 KB) - added by emaros 4 years ago.

Download all attachments as: .zip

Change History (14)

Changed 4 years ago by emaros

Attachment: Portfile added

comment:1 Changed 4 years ago by mf2k (Frank Schima)

Keywords: haspatch removed
Version: 2.3.4

See #51625.

comment:2 Changed 4 years ago by ryandesign (Ryan Schmidt)

This port should not be marked as conflicting with ldas-tools. Your current ldas-tools submission is marked replaced_by ldas-tools-as. As such, the conflicts marking will prevent the replacement from working. My suggestion was to make ldas-tools a meta port; in that case, you would not want a conflicts marking either; instead, you would want to use the deactivate hack.

You shouldn't base the decision about whether to use C++11 on whether the OS X version is Mavericks or greater. Instead, you should base it on whether configure.cxx_stdlib equals libc++.

The openssl dependency should be written in such a way that libressl could satisfy it. See other ports that depend on openssl for the correct syntax.

comment:3 Changed 4 years ago by ryandesign (Ryan Schmidt)

configure.args-strsed is ancient. You should probably use configure.args-replace instead. (configure.args-replace --disable-python --enable-python)

It doesn't look like the livecheck has been updated for the changed distfile names.

comment:4 in reply to:  3 Changed 4 years ago by emaros

Replying to ryandesign@…:

configure.args-strsed is ancient. You should probably use configure.args-replace instead. (configure.args-replace --disable-python --enable-python)

It doesn't look like the livecheck has been updated for the changed distfile names.

I have opened a ticket for this on the main ticketing system for the software package and will make the modification for the next release of the software.

comment:5 Changed 4 years ago by skymoo (Adam Mercer)

Owner: changed from macports-tickets@… to ram@…
Status: newassigned

comment:6 Changed 4 years ago by skymoo (Adam Mercer)

Resolution: fixed
Status: assignedclosed

comment:7 in reply to:  3 Changed 4 years ago by ryandesign (Ryan Schmidt)

Replying to ryandesign@…:

You shouldn't base the decision about whether to use C++11 on whether the OS X version is Mavericks or greater. Instead, you should base it on whether configure.cxx_stdlib equals libc++.

The openssl dependency should be written in such a way that libressl could satisfy it. See other ports that depend on openssl for the correct syntax.

Replying to ryandesign@…:

configure.args-strsed is ancient. You should probably use configure.args-replace instead. (configure.args-replace --disable-python --enable-python)

It doesn't look like the livecheck has been updated for the changed distfile names.

These issues should have been resolved before committing.

comment:8 Changed 4 years ago by skymoo (Adam Mercer)

Resolution: fixed
Status: closedreopened

Apologies I was under the impression that these issues had been addressed, I didn't check too closely.

Ed: Can you get a patch together to address these issues?

Changed 4 years ago by emaros

Attachment: Portfile-ldas-tools-al.diff added

comment:9 in reply to:  8 Changed 4 years ago by emaros

Replying to ram@…:

Apologies I was under the impression that these issues had been addressed, I didn't check too closely.

Ed: Can you get a patch together to address these issues?

The patch file addresses all of the issues mentioned above.

comment:10 Changed 4 years ago by skymoo (Adam Mercer)

Thanks Ed,

Ryan: Are you happy with these changes?

comment:11 Changed 4 years ago by skymoo (Adam Mercer)

Cc: ryandesign@… added

Ryan: Do the attached changes address your concerns?

comment:12 Changed 4 years ago by skymoo (Adam Mercer)

Resolution: fixed
Status: reopenedclosed

I'm with with Ed off list on an update to this port that address these issues along with updating to the next version. I'm going to close this ticket out as to avoid confusion when we're ready to submit the update.

Note: See TracTickets for help on using tickets.