Opened 3 years ago

Closed 3 years ago

#51645 closed defect (fixed)

cfitsio @3.390 not setting compatibility and current version correctly

Reported by: aszostak-partner-eso-org Owned by: cdeil (Christoph Deil)
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: Schamschula (Marius Schamschula), Russell-Jones-OxPhys (Russell Jones)
Port: cfitsio

Description (last modified by ryandesign (Ryan Schmidt))

The patch-configure.diff patch is clobbering the original code in the configure script that sets the compatibility and current version of the dylib library using the -compatibility_version -current_version flags (browser:trunk/dports/science/cfitsio/files/patch-configure.diff?rev=148197). This appears to produce 3.390 shared libraries that look to MacPorts like they are compatible with 3.340. But this is not the case. On Linux systems the 3.390 shared libraries have different sonames compared to the 3.340 libraries. The net result is that binaries delivered with MacPorts that depend on cfitsio, are not being recompiled after an upgrade to a cfitsio version that has a different soname.

Attachments (1)

patch.txt (1.3 KB) - added by aszostak-partner-eso-org 3 years ago.
Patch to fix setting of library versions.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 3 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)
Owner: changed from macports-tickets@… to Deil.Christoph@…

Agreed, the patch should not clobber the current version and compatibility version. The purpose of the patch was originally to add the install name, since upstream did not set it. Now that upstream does set install name and compatibility version and current version, that might no longer need to be patched. Once that's fixed, cfitsio's revision will need to be increased since this fix will change the installed files.

Regarding other binaries linked with cfitsio's libraries needing a recompile: those ports should have their revisions increased after the above is fixed.

comment:2 Changed 3 years ago by ryandesign (Ryan Schmidt)

Cc: mps@… added

Changed 3 years ago by aszostak-partner-eso-org

Attachment: patch.txt added

Patch to fix setting of library versions.

comment:3 Changed 3 years ago by aszostak-partner-eso-org

Hi, could the attached patch please be reviewed and applied. I need to get this ticket solved. Thanks.

comment:4 Changed 3 years ago by Russell-Jones-OxPhys (Russell Jones)

Cc: russell.jones@… added

Cc Me!

comment:5 Changed 3 years ago by raimue (Rainer Müller)

Resolution: fixed
Status: newclosed

Committed with rev-bumps in r150613.

Note: See TracTickets for help on using tickets.