get_iplayer @2.94: new port

[dliessi (Davide Liessi)]

Solves #19396.

The port works also with Perl 5.24, but I set perl5.branches 5.22 since it is currently the default Perl.

[dliessi (Davide Liessi)]

Depends on p5-net-smtp-tls-butmaintained, submitted in #51666

[dbevans (David B. Evans)]

Replying to davide.liessi@…:

Solves #19396.

The port works also with Perl 5.24, but I set perl5.branches 5.22 since it is currently the default Perl.

A typical way to handle this is to declare variants to allow selection of the perl to use. See attached patch to your Portfile that implements variants +perl5_22 +perl5_24 (default +perl5_22) using the perl5 PortGroup.

[dbevans (David B. Evans)]

Proposed patch adding variants to select perl version

[dbevans (David B. Evans)]

On testing, I found that although I can list programs available on the iPlayer site, I get an error when trying to download or stream videos (I was hoping to download some S4C Welsh language programs)

$ get_iplayer Heini
get_iplayer v2.94, Copyright (C) 2008-2010 Phil Lewis
  This program comes with ABSOLUTELY NO WARRANTY; for details use --warranty.
  This is free software, and you are welcome to redistribute it under certain
  conditions; use --conditions for details.

Matches:
488:	Heini: Cyfres 1 - Traeth, S4C, , default
489:	Heini: Cyfres 1 - Chware, S4C, , default
490:	Heini: Cyfres 1 - Anifeiliaid, S4C, , default
491:	Heini: Cyfres 1 - Llyn, S4C, , default

INFO: 4 Matching Programmes

$ get_iplayer 488 --get
get_iplayer v2.94, Copyright (C) 2008-2010 Phil Lewis
  This program comes with ABSOLUTELY NO WARRANTY; for details use --warranty.
  This is free software, and you are welcome to redistribute it under certain
  conditions; use --conditions for details.

Matches:
488:	Heini: Cyfres 1 - Traeth, S4C, , default

INFO: 1 Matching Programmes
WARNING: The 'default' programme version could not be determined
WARNING: No programme versions found
WARNING: You may receive this message if you are using get_iplayer outside the UK

Apparently this is not a fault of get_iplayer itself but a policy of the iPlayer site not to allow downloads/streaming from IPs outside the UK. I'm in California.

Perhaps you should add something (description, notes) that notifies the potential user of this limitation.

[dliessi (Davide Liessi)]

Replying to devans@…:

Apparently this is not a fault of get_iplayer itself but a policy of the iPlayer site not to allow downloads/streaming from IPs outside the UK. I'm in California.

Indeed downloading/streaming TV programmes from outside the UK is not permitted by BBC policy. However, the port is useful also outside the UK, because radio programmes can be downloaded from anywhere.

Perhaps you should add something (description, notes) that notifies the potential user of this limitation.

I will add a note specifying the above.

[dliessi (Davide Liessi)]

Replying to devans@…:

A typical way to handle this is to declare variants to allow selection of the perl to use. See attached patch to your Portfile that implements variants +perl5_22 +perl5_24 (default +perl5_22) using the perl5 PortGroup.

Thanks! I'll apply the patch to the Portfile and submit it again.

[dliessi (Davide Liessi)]

add Perl variants; add note on use outside UK

[dliessi (Davide Liessi)]

Changes done, see attached Portfile.2.

[dbevans (David B. Evans)]

Looks good. Updated port committed in r149946. Thanks for your submission and for stepping up as maintainer.