Opened 4 years ago

Closed 11 days ago

#51722 closed enhancement (fixed)

molden: also build and install gmolden

Reported by: josh.baraban@… Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: jochen@…
Port: molden

Description (last modified by ryandesign (Ryan Schmidt))

The checksums for molden 5.6 are wrong (this appears to be a recurring problem), and it would be nice if the build targets included gmolden. Everything seems to work if I manually change the checksums and add gmolden to build-target (and xinstall it). Changes to the Portfile:

checksums           rmd160  dd420615b664b52ecac73e36892b8dc0c316cb33 \
                    sha256  1d1790c7f60b200aa3454c8b5f38bb866181d3c30e8f1c9fb466ee183d899ebf
build.target        molden gmolden
    xinstall -W ${worksrcpath} molden gmolden ${destroot}${prefix}/bin

Change History (5)

comment:1 Changed 4 years ago by ryandesign (Ryan Schmidt)

Description: modified (diff)
Owner: changed from macports-tickets@… to ryandesign@…
Status: newassigned
Summary: molden 5.6 checksums are wrong, and build targets need updatingmolden: checksums are wrong, and build targets need updating

comment:2 Changed 4 years ago by ryandesign (Ryan Schmidt)

Cc: jochen@… added
Summary: molden: checksums are wrong, and build targets need updatingmolden: also build and install gmolden
Type: defectenhancement
Version: 2.3.4

It's best to submit separate issues in separate tickets so that we can resolve them separately. I updated the port to the latest version in r149820 which should fix the checksum mismatch problem, until the next update appears.

Regarding gmolden, I understand that's an OpenGL version of Molden. There's already the opengl variant which installs moldenogl. Does it make sense to add the installation of gmolden into that variant? Or conversely does it make sense to remove the opengl variant and always install molden, gmolden and moldenogl? I'm not familiar with the Molden software so I don't know the relationship between these programs and how they're used so it's hard for me to know how we should package it.

Jochen, if you have any thoughts, let me know.

comment:3 in reply to:  2 Changed 4 years ago by josh.baraban@…

According to the molden website, moldenogl is entirely superseded by gmolden:

http://www.cmbi.ru.nl/molden/opengl.html

I don't see any reason not to install gmolden by default, and leave the +opengl variant if people need moldenogl for some reason.

Thanks,

Josh

comment:4 Changed 3 years ago by valerievallet

Hi all, I wish to comment on your post... to support that golden should be installed by default, since the molden website says that "Although moldenogl is now obsolete it is still functional."​ http://www.cmbi.ru.nl/molden/opengl.html

gmolden must be compiled together with molden as done in the linux tarball.

Could you please consider Ryan's suggestion to update the Portfile.

build.target        molden gmolden
xinstall -W ${worksrcpath} molden gmolden ${destroot}${prefix}/bin

Thanks a lot for your help. Valérie

comment:5 Changed 11 days ago by ryandesign (Ryan Schmidt)

Resolution: fixed
Status: assignedclosed

In 2a765437fbb511c7b25e93db1e3130e28fd458a4/macports-ports (master):

molden: Update to 6.4-20200625124000 and build all

Now build and install all targets including gmolden, not just the molden
target.

Remove the opengl variant because the moldenogl target has been removed
from the makefile. It's still in makefile.old so it could possibly be
brought back, but moldenogl seems to be superseded by gmolden.

Closes: #51722

Note: See TracTickets for help on using tickets.