Opened 8 years ago

Closed 8 years ago

#51779 closed defect (fixed)

texlive-bin @2016 fails to build on 10.7 (use of alignof)

Reported by: jmroot (Joshua Root) Owned by: drkp (Dan Ports)
Priority: Normal Milestone:
Component: ports Version:
Keywords: lion haspatch Cc: mojca (Mojca Miklavec)
Port: texlive-bin

Description

Seems to be assuming C11 feature availability.

Attachments (4)

main.log.gz (146.1 KB) - added by jmroot (Joshua Root) 8 years ago.
patch-texk_gregorio_gregorio-src_src_sha1.c.diff (330 bytes) - added by jmroot (Joshua Root) 8 years ago.
Portfile.diff (682 bytes) - added by jmroot (Joshua Root) 8 years ago.
patch-gregorio-alignof.diff (10.8 KB) - added by mojca (Mojca Miklavec) 8 years ago.
Backporting upstream patch for alignof for gregorio

Download all attachments as: .zip

Change History (13)

Changed 8 years ago by jmroot (Joshua Root)

Attachment: main.log.gz added

comment:1 Changed 8 years ago by jmroot (Joshua Root)

Looks like it uses alignof whenever stdalign.h is present, but older versions of that header don't have alignof (just alignas).

comment:2 Changed 8 years ago by jmroot (Joshua Root)

The header was added in Xcode 4.3 but the alignof macro didn't appear until Xcode 5.0.

Changed 8 years ago by jmroot (Joshua Root)

Changed 8 years ago by jmroot (Joshua Root)

Attachment: Portfile.diff added

comment:3 Changed 8 years ago by jmroot (Joshua Root)

Keywords: haspatch added

This patch does the trick for me.

comment:4 Changed 8 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

comment:5 Changed 8 years ago by mojca (Mojca Miklavec)

Version: 2.3.4

comment:6 Changed 8 years ago by mojca (Mojca Miklavec)

This has been fixed in a very elegant way upstream, but it requires a patch for configure, so a bit more work.

Last edited 8 years ago by mojca (Mojca Miklavec) (previous) (diff)

Changed 8 years ago by mojca (Mojca Miklavec)

Attachment: patch-gregorio-alignof.diff added

Backporting upstream patch for alignof for gregorio

comment:7 Changed 8 years ago by mojca (Mojca Miklavec)

I attached a patch. It seems to solve the problem on Lion.

(I can also commit it if Dan is OK with it).

comment:8 Changed 8 years ago by drkp (Dan Ports)

Go for it!

comment:9 Changed 8 years ago by mojca (Mojca Miklavec)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.