Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#51785 closed update (fixed)

Qalculate update

Reported by: jjstickel (Jonathan Stickel) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch maintainer Cc:
Port: libqalculate qalculate-gtk

Description

A new version of Qalculate has been released. Patches for the portfiles libqalculate and qalculate-gtk are attached.

Attachments (3)

libqalculate_Portfile.diff (1.8 KB) - added by jjstickel (Jonathan Stickel) 3 years ago.
libqalculate_unordered.patch (656 bytes) - added by jjstickel (Jonathan Stickel) 3 years ago.
qalculate-gtk_Portfile.diff (2.2 KB) - added by jjstickel (Jonathan Stickel) 3 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 3 years ago by mf2k (Frank Schima)

Comments:

  • Since you are (wisely) switching to the github portgroup, all depends_* statements should be changed to depends_*-append to not overwrite the portgroup dependencies.
  • It looks like you are referencing the patchfile libqalculate_unordered.patch but that is not attached to this ticket.

Changed 3 years ago by jjstickel (Jonathan Stickel)

Attachment: libqalculate_Portfile.diff added

Changed 3 years ago by jjstickel (Jonathan Stickel)

Changed 3 years ago by jjstickel (Jonathan Stickel)

Attachment: qalculate-gtk_Portfile.diff added

comment:2 in reply to:  1 Changed 3 years ago by jjstickel (Jonathan Stickel)

Replying to mf2k@…:

Comments:

  • Since you are (wisely) switching to the github portgroup, all depends_* statements should be changed to depends_*-append to not overwrite the portgroup dependencies.
  • It looks like you are referencing the patchfile libqalculate_unordered.patch but that is not attached to this ticket.

Thanks for the review. Depends statements fixed in the new attachments. The patchfile for libqalculate is also now attached.

comment:3 Changed 3 years ago by mf2k (Frank Schima)

Keywords: haspatch maintainer added
Resolution: fixed
Status: newclosed
Version: 2.3.4

r150009.

Would you mind if I fix up the spacing a little on these ports? Also I want to remove the reference to "for GNU/Linux" in the description for qalculate-gtk.

comment:4 in reply to:  3 Changed 3 years ago by jjstickel (Jonathan Stickel)

Replying to mf2k@…:

r150009.

Would you mind if I fix up the spacing a little on these ports? Also I want to remove the reference to "for GNU/Linux" in the description for qalculate-gtk.

Go ahead. I thought about adjusting the description and some spacing issues, but I didn't want to add clutter to the portfile diffs.

I use emacs (emacs-app), and it doesn't do the spacing automatically, even with the correct header line. Is there a trick to this?

comment:5 Changed 3 years ago by mf2k (Frank Schima)

Updated in r150010 and r150011. I just use BBEdit and manually adjust the spacing. I have it set to convert tabs to spaces.

Note: See TracTickets for help on using tickets.