Opened 4 years ago

Closed 4 years ago

#51940 closed submission (fixed)

Add SoapySDR to Macports

Reported by: gedgy63@… Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: SoapySDR

Description

Please find attached new Portfile for adding SoapySDR to Macports.

Attachments (1)

Portfile (1.3 KB) - added by gedgy63@… 4 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 4 years ago by ryandesign (Ryan Schmidt)

Keywords: soapysdr sir removed

Thanks! Some notes:

  • Because this project is hosted on github, the port should use the github portgroup.
  • Is there a reason why the portfile is programmed to fetch from git? Usually we want to fetch a tarball instead. See the documentation in the comments at the top of the github 1.0 portgroup file.
  • The maintainers line should list your valid email address in our obfuscated "host:user" format. Omitting the "host:" part as you've done implies that the host is macports.org.

comment:2 Changed 4 years ago by gedgy63@…

Thanks for the heads up, first time submitting and I just followed the documentation...or so I thought!

Have now updated the Portfile to use the github Portgroup, used tar file, and updated maintainer.

I hope that looks better?

comment:3 Changed 4 years ago by gedgy63@…

When will this be actioned?

thanks

Richard

comment:4 Changed 4 years ago by mf2k (Frank Schima)

More (minor) notes:

  • The maintainer "gedgy63" is not valid because you are not a Macports committer, so remove that part. Also consider adding openmaintainer.
  • The layout of your Portfile is non-normal. For instance, the github.setup line is usually right after the Portgroup line(s).

comment:5 Changed 4 years ago by gedgy63@…

OK have done some reordering and removed offending line.

I hope that's OK now?

Richard

Changed 4 years ago by gedgy63@…

Attachment: Portfile added

comment:6 Changed 4 years ago by gedgy63@…

Any chance of getting this actioned.

Thanks

Richard

comment:7 Changed 4 years ago by mf2k (Frank Schima)

Port: SoapySDR added; soapysdr removed
Resolution: fixed
Status: newclosed
Version: 2.3.4

Thank you for your patience. r151954.

Note: See TracTickets for help on using tickets.