darkice needs pkgconfig dependency

[ryandesign (Ryan Carsten Schmidt)]

darkice 1.3 fails to build:

​https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/1812

checking for cc_r... /usr/bin/clang
checking for lame library at /opt/local ... found at /opt/local 
checking for VORBIS... no
checking for OPUS... no
checking for faac library at /usr ... configure: WARNING: not found, building without faac
checking for AACPLUS... no
checking for TWOLAME... no
checking for ALSA... no
checking for PULSEAUDIO... no
checking for JACK... no
configure: error: in `/opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_dports_audio_darkice/darkice/work/darkice-1.3':
configure: error: The pkg-config script could not be found or is too old.  Make sure it
is in your PATH or set the PKG_CONFIG environment variable to the full
path to pkg-config.

Alternatively, you may set the environment variables JACK_CFLAGS
and JACK_LIBS to avoid the need to call pkg-config.
See the pkg-config man page for more details.

To get pkg-config, see <http://pkg-config.freedesktop.org/>.
See `config.log' for more details

Evidently, darkice needs pkgconfig to find jack, so a build dependency on port:pkgconfig should be added to the port somewhere. But where?

If only the jack variant needs pkgconfig, then put the dependency in the jack variant.

It looks lame was detected without pkgconfig. What about the other variants, which are not default variants? If some of them require pkgconfig, then the pkgconfig dependency should be made in a conditional outside of a variant directive (to avoid each variant declaring the same dependency). For example, if only jack and faac need pkgconfig, you could do:

if {[variant_isset faac] || [variant_isset jack]} {
    depends_build-append port:pkgconfig
}

[ryandesign (Ryan Carsten Schmidt)]

The discussion moved to the mailing list, where we decided that everything except lame requires pkgconfig, so it's ok to just add a general pkgconfig dependency, as in the attached patch.

[kurthindenburg (Kurt Hindenburg)]

looks like this was committed

r152311 | ryandesign@macports.org | 2016-09-03 09:54:11 -0400 (Sat, 03 Sep 2016) | 2 lines

darkice: add pkgconfig dependency (#52051; maintainer)