Unable to compile mosh 1.2.6_0

[letaage]

I am trying to update mosh from 1.2.5_0 to 1.2.6_0 on OS X 10.8.3, it fails to compile with an error:

info:build ocb.cc:393:3: error: use of undeclared identifier 'kCCAlgorithmAES'; did you mean 'kCCAlgorithmDES'?
:info:build                 kCCAlgorithmAES,
:info:build                 ^~~~~~~~~~~~~~~
:info:build                 kCCAlgorithmDES
:info:build /usr/include/CommonCrypto/CommonCryptor.h:151:5: note: 'kCCAlgorithmDES' declared here
:info:build     kCCAlgorithmDES,        
:info:build     ^
:info:build ocb.cc:409:3: error: use of undeclared identifier 'kCCAlgorithmAES'; did you mean 'kCCAlgorithmDES'?
:info:build                 kCCAlgorithmAES,
:info:build                 ^~~~~~~~~~~~~~~
:info:build                 kCCAlgorithmDES
:info:build /usr/include/CommonCrypto/CommonCryptor.h:151:5: note: 'kCCAlgorithmDES' declared here
:info:build     kCCAlgorithmDES,        
:info:build     ^
:info:build 2 errors generated.
:info:build make[3]: *** [ocb.o] Error 1
:info:build make[3]: *** Waiting for unfinished jobs....
:info:build make[3]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_mosh/mosh/work/mosh-1.2.6/src/crypto'
:info:build make[2]: *** [all-recursive] Error 1
:info:build make[2]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_mosh/mosh/work/mosh-1.2.6/src'
:info:build make[1]: *** [all-recursive] Error 1
:info:build make[1]: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_mosh/mosh/work/mosh-1.2.6'
:info:build make: *** [all] Error 2
:info:build make: Leaving directory `/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_mosh/mosh/work/mosh-1.2.6'
:info:build Command failed:  cd "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_mosh/mosh/work/mosh-1.2.6" && /usr/bin/make -j2 -w all 
:info:build Exit code: 2
:error:build org.macports.build for port mosh returned: command execution failed
:debug:build Error code: CHILDSTATUS 90478 2
:debug:build Backtrace: command execution failed
    while executing
"system -nice 0 $fullcmdstring"
    ("eval" body line 1)
    invoked from within
"eval system $notty $nice \$fullcmdstring"
    invoked from within
"command_exec build"
    (procedure "portbuild::build_main" line 8)
    invoked from within
"portbuild::build_main org.macports.build"
    ("eval" body line 1)
    invoked from within
"eval $procedure $targetname"
:info:build Warning: targets not executed for mosh: org.macports.install org.macports.build org.macports.destroot
:notice:build Please see the log file for port mosh for details:
    /opt/local/var/macports/logs/_opt_local_var_macports_sources_rsync.macports.org_release_tarballs_ports_net_mosh/mosh/main.log

I am not sure how to approach fixing this...

[letaage]

Compilation Log file

[neverpanic (Clemens Lang)]

Please use WikiFormatting, preview your post, fill the port field and Cc the maintainer(s), if any.

It seems Apple's CommonCrypto on 10.8.3 does not support AES encryption? We could avoid this by switching to OpenSSL again, but I would have preferred to avoid the dependency.

[neverpanic (Clemens Lang)]

Oh, it seems kCCAlgorithmAES didn't exist in older versions of CommonCrypto/CommonCryptor.h and was instead named kCCAlgorithmAES128. The new constant was added in CommonCrypto-60049 and is an alias for kCCAlgorithmAES128. I think upstream should decide whether to use kCCAlgorithmAES128.

[quentinmit (Quentin Smith)]

This is ​https://github.com/mobile-shell/mosh/issues/804

I would recommend disabling CommonCrypto for now.

[neverpanic (Clemens Lang)]

OK, switched back to OpenSSL in r152583.

[neverpanic (Clemens Lang)]

In 216bfe002ea78203d6ad4bfd19926147a95637d3/macports-ports:

mosh: 1.3.0, switch to CommonCrypto

Update to 1.3.0 and switch back to CommonCrypto, dropping the OpenSSL
dependency now that older systems should work with CommonCrypto with

#52222

fixed upstream.

This reverts commit fbcb8396fcf918f4fdf0da2519ed259e724d192f.

Closes: #53870
See: #52222