#52231 closed defect (fixed)
libphonenumber-cpp Problem with Long values in test
| Reported by: | arboz | Owned by: | dbevans (David B. Evans) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | 2.3.4 |
| Keywords: | leopard i386 haspatch | Cc: | |
| Port: | libphonenumber-cpp |
Description
There has been the recurring issue of use of Long values in the test I seem to remember that it was fixed upstream, but as of last version upgrade it appeared again
I constructed a patch to show the changes
however I suppose it is better to send upstream
Attachments (1)
Change History (5)
Changed 8 years ago by arboz
| Attachment: | patch-src-phonenumberutil_test.cc.diff added |
|---|
comment:1 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
| Cc: | devans@… openmaintainer@… removed |
|---|---|
| Keywords: | haspatch added |
| Owner: | changed from macports-tickets@… to devans@… |
comment:2 Changed 8 years ago by dbevans (David B. Evans)
| Status: | new → assigned |
|---|
Thanks for the report and patch. Yes, I suggest you report this upstream so it gets fixed there and add a pointer to the resulting issue/PR to this ticket so we can track it. In the meantime I'll apply your fix to the current version.
comment:3 Changed 8 years ago by dbevans (David B. Evans)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Committed in r152625. Looks like this was a case of new test code that wasn't careful about declaring large longs. Previously existing code declares these properly.
comment:4 Changed 8 years ago by arboz
Thanks,
I put a comment with a copy of the patch on the GITHUB Issues
https://github.com/googlei18n/libphonenumber/issues/1334
number 1334
sample src-patch to fix Long values in cpp/test libphonenumber-cpp