Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#52291 closed enhancement (fixed)

neomutt @20160919 disable opportunistic linking

Reported by: lbschenkel (Leonardo Brondani Schenkel) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc:
Port: neomutt

Description

The neomutt Portfile was copied from the mutt port and inherited the issue reported on #52267 in which it will opportunistically pick up locally installed libraries without having an explicit dependency declared in the Portfile — what results in breakage if the library is later uninstalled.

I believe I fixed all instances of opportunistic linking. I also explicitly disabled all the features controlled by variants even though they may already be disabled by default to make the port more resilient against defaults changing in future versions.

In the process of doing this I found out that there are additional features that could/should have new variants and current hardcoded dependencies that could be made optional. Since I have limited time at the moment I focused just on fixing the current variants. As soon as I get the chance I'll submit the new variants on a new ticket.

Attachments (1)

neomutt.patch (6.6 KB) - added by lbschenkel (Leonardo Brondani Schenkel) 5 years ago.

Download all attachments as: .zip

Change History (4)

Changed 5 years ago by lbschenkel (Leonardo Brondani Schenkel)

Attachment: neomutt.patch added

comment:1 Changed 5 years ago by neverpanic (Clemens Lang)

Resolution: fixed
Status: newclosed

Committed in r152935 with two changes:

  • The idn variant used --without-idb where it should have been --without-idn.
  • Passing --without-slang completely disables searching for ncurses and tries to find ncurses in -Lno/lib. This is a bug in mutt's configure script.
Version 0, edited 5 years ago by neverpanic (Clemens Lang) (next)

comment:2 Changed 5 years ago by lbschenkel (Leonardo Brondani Schenkel)

Thanks for catching the typo/mistake. I'll need to test the changes better in the future before sending the patch.

comment:3 Changed 5 years ago by neverpanic (Clemens Lang)

Don't worry, that's why I test before I commit. Thanks for working on these issues.

Note: See TracTickets for help on using tickets.