Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#52309 closed enhancement (fixed)

ipcalc: use perl 5.24

Reported by: xeron (Ivan Larionov) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc:
Port: ipcalc

Description

Changes for ipcalc port:

  • Use perl5 PortGroup and perl 5.24
  • use sha256, drop md5 and sha1
  • Consistent tabulation

Attachments (3)

ipcalc.patch (2.8 KB) - added by xeron (Ivan Larionov) 10 years ago.
01_ipcalc_whitespace.patch (2.8 KB) - added by xeron (Ivan Larionov) 10 years ago.
02_ipcalc.patch (1.4 KB) - added by xeron (Ivan Larionov) 10 years ago.

Download all attachments as: .zip

Change History (11)

Changed 10 years ago by xeron (Ivan Larionov)

Attachment: ipcalc.patch added

comment:1 Changed 10 years ago by dbevans (David B. Evans)

To make it easier to see what's being changed, it's usually preferable to split an update like this into two separate patches/commits. First a patch to deal with the tabulation issue and then a second to make the other changes.

comment:2 Changed 10 years ago by xeron (Ivan Larionov)

@devans ok. Thank you. Uploading 2 separate patches.

Changed 10 years ago by xeron (Ivan Larionov)

Attachment: 01_ipcalc_whitespace.patch added

comment:3 Changed 10 years ago by mf2k (Frank Schima)

Some comments:

  • Do you mean to remove the line: supported_archs noarch?
  • The line: depends_lib port:perl${perl5.major} can be removed because the perl5 portgroup already adds it.

Changed 10 years ago by xeron (Ivan Larionov)

Attachment: 02_ipcalc.patch added

comment:4 Changed 10 years ago by xeron (Ivan Larionov)

@mf2k thank you for comments, I returned supported_archs.

I did not remove depends_lib since port dependents perl5.24 doesn't show ipcalc w/o it so I'm not sure it could be removed.

comment:5 Changed 10 years ago by mf2k (Frank Schima)

I see. It must be the perl5.setup command that actually sets that dependency, but you are not using that.

comment:6 Changed 10 years ago by xeron (Ivan Larionov)

@mf2k I think I'll keep this variant with depends_lib. I only use perlgroup to get perl5.major variable and looks like perl5.setup is mostly used for perl modules to set ${distfile} and ${version} which I don't need here.

Last edited 10 years ago by xeron (Ivan Larionov) (previous) (diff)

comment:7 Changed 10 years ago by mf2k (Frank Schima)

Resolution: fixed
Status: newclosed
Version: 2.3.4

comment:8 Changed 10 years ago by xeron (Ivan Larionov)

Thank you!

Note: See TracTickets for help on using tickets.