Opened 8 years ago
Closed 8 years ago
#52354 closed enhancement (fixed)
links @2.12_1 update to 2.13 and fix dependencies / add variants
| Reported by: | lbschenkel (Leonardo Brondani Schenkel) | Owned by: | ryandesign (Ryan Carsten Schmidt) |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | ports | Version: | |
| Keywords: | haspatch | Cc: | |
| Port: | links |
Description
I have upgrade Links to 2.13 and I have improved the Portfile. The previous versions had problems of opportunistic linking and requiring libjpeg and libpng even if graphics support was disabled. I have added two additional variants for TIFF and SVG support.
Attachments (1)
Change History (5)
comment:1 Changed 8 years ago by mf2k (Frank Schima)
| Keywords: | haspatch added |
|---|---|
| Type: | update → enhancement |
| Version: | 2.3.4 |
comment:2 Changed 8 years ago by lbschenkel (Leonardo Brondani Schenkel)
I am not sure of what you mean. +tiff requires libtiff and +svg requires librsvg. These two libraries were not declared as dependencies before (however, the port would erroneously link to them if +x11 was enabled). librsvg in particular will bring a large number of dependencies, and since most browsers don't support TIFF I thought it was a good idea to leave these two optional.
I noticed that my patch has a typo. I'm going to submit a new version.
Changed 8 years ago by lbschenkel (Leonardo Brondani Schenkel)
| Attachment: | links.patch added |
|---|
patch to Portfile
comment:3 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
| Owner: | changed from macports-tickets@… to ryandesign@… |
|---|---|
| Status: | new → assigned |
Thanks. I think the variants are fine.
comment:4 Changed 8 years ago by ryandesign (Ryan Carsten Schmidt)
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
I quoted the variant descriptions, and changed the libtiff dependency to tiff.
Thank you for the patch. Since the variants do not apparently add any dependencies, why not always enable TIFF and SVG support? Even if they do add dependencies, I think they should be enabled always unless there is a license issue.