Opened 5 years ago

Closed 3 years ago

Last modified 3 years ago

#52445 closed enhancement (fixed)

portpatch.tcl: support xz-compressed patchfiles

Reported by: ryandesign (Ryan Schmidt) Owned by: macports-tickets@…
Priority: Normal Milestone: MacPorts 2.5.0
Component: base Version:
Keywords: Cc: larryv (Lawrence Velázquez), mojca (Mojca Miklavec), kurthindenburg (Kurt Hindenburg)
Port:

Description

portpatch.tcl already automatically handles patchfiles whose names end with .Z, .gz and .bz2, passing them through the appropriate decompressor first. Add support for xz-compressed files.

The complication is that a dependency on port:xz would have to be added since macOS doesn't include it.

Change History (9)

comment:1 Changed 5 years ago by larryv (Lawrence Velázquez)

Cc: larryv@… added

Cc Me!

comment:2 Changed 3 years ago by mojca (Mojca Miklavec)

Cc: mojca added

comment:3 Changed 3 years ago by mojca (Mojca Miklavec)

Milestone: MacPorts 2.6.0

comment:4 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

Cc: kurthindenburg added

My attempt at adding depends_patch https://github.com/macports/macports-base/pull/66

If committed, I'll make another pull to use it for patches.

comment:5 Changed 3 years ago by Kurt Hindenburg <kurt.hindenburg@…>

In a74c159d4321cfda67b9756cc641a02884e086c4/macports-base:

Add depends_patch to handle the patch dependencies of ports

This can be used to handle xz patches in the below trac ticket (which
requires another patch to base).

See #52445

comment:6 Changed 3 years ago by kurthindenburg (Kurt Hindenburg)

https://github.com/macports/macports-base/pull/67

Note that this doesn't allow use of tar.xz patch files such as w3m_0.5.3-36.debian.tar.xz - that would need another patch

comment:7 in reply to:  6 Changed 3 years ago by ryandesign (Ryan Schmidt)

Replying to kurthindenburg:

Note that this doesn't allow use of tar.xz patch files such as w3m_0.5.3-36.debian.tar.xz - that would need another patch

I would consider that a completely separate feature, to be dealt with in another ticket, following perhaps first a mailing list discussion in which the feature is proposed and specified. MacPorts doesn't support .tar.gz or .tar.bz2 "patch files" either. A tar file could (and the example w3m_0.5.3-36.debian.tar.xz file does) contain multiple files, not all of which are patches; it's not immediately clear how or if MacPorts should handle that.

comment:8 Changed 3 years ago by Kurt Hindenburg <kurt.hindenburg@…>

Resolution: fixed
Status: newclosed

In 5a142fd203557a6d2f03d580affed9d4aad3ffd4/macports-base:

Add the ability to handle xz patch files

closes #52445

comment:9 Changed 3 years ago by jmroot (Joshua Root)

Milestone: MacPorts 2.6.0MacPorts 2.5.0
Note: See TracTickets for help on using tickets.