Opened 4 years ago

Closed 4 years ago

#52453 closed submission (fixed)

py-llfuse @1.1.1: new port

Reported by: bket Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: mojca (Mojca Miklavec)
Port:

Description

Please find enclosed a port for Python-LLFUSE. The latter is a set of Python bindings for the low level FUSE API.

Attachments (2)

Portfile.2 (1.2 KB) - added by bket 4 years ago.
Portfile (1.2 KB) - added by bket 4 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 4 years ago by mojca (Mojca Miklavec)

A few minor comments:

  • Why don't you add yourself as a maintainer (ideally with openmaintainer)?
  • Isn't 'port:py${python.version}-setuptools' a build dependency?
  • You can probably use 'use_bzip2 yes' instead of 'extract.suffix .tar.bz2'

Other than that the Portfile looks clean and straightforward.

comment:2 Changed 4 years ago by mojca (Mojca Miklavec)

Cc: mojca@… added

Cc Me!

Changed 4 years ago by bket

Attachment: Portfile.2 added

Changed 4 years ago by bket

Attachment: Portfile added

comment:3 Changed 4 years ago by bket

Thanks for your feedback. Portfile has been updated:

--- Portfile.orig	2016-10-03 19:30:15.000000000 +0200
+++ Portfile	2016-10-03 20:05:03.000000000 +0200
@@ -9,14 +9,14 @@ version             1.1.1
 categories-append   devel fuse
 platforms           darwin
 license             LGPL-2+
-maintainers         nomaintainer
+maintainers         hydroxide.nl:bjorn.ketelaars openmaintainer

 description         Python bindings for the low-level FUSE API
 long_description    Python-LLFUSE is a set of Python bindings for the low \
                     level FUSE API.

 distname            llfuse-${version}
-extract.suffix      .tar.bz2
+use_bzip2           yes

 homepage            https://pypi.python.org/pypi/llfuse/
 master_sites        pypi:l/llfuse
@@ -27,9 +27,9 @@ checksums           rmd160  96c560c5710b
 python.versions     27 34 35

 if {${name} ne ${subport}} {
-    depends_build-append    port:pkgconfig
-    depends_lib-append      port:osxfuse \
+    depends_build-append    port:pkgconfig \
                             port:py${python.version}-setuptools
+    depends_lib-append      port:osxfuse

     livecheck.type          none
 } else {

py-setuptools is indeed a build dependency. There is no need for the pkg_resources module it provides.

OK?

Last edited 4 years ago by bket (previous) (diff)

comment:4 Changed 4 years ago by g5pw (Aljaž Srebrnič)

Resolution: fixed
Status: newclosed

Thanks for your contribution, commited in r153557. Welcome!

Note: See TracTickets for help on using tickets.