nxcomp: cp: illegal option -- a

[ryandesign (Ryan Carsten Schmidt)]

nxcomp builds but fails to destroot on Leopard:

​https://build.macports.org/builders/ports-10.5_ppc_legacy-builder/builds/5978

cp -av libXcomp.3.dylib              /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_net_nxcomp/nxcomp/work/destroot/opt/local/lib
cp: illegal option -- a
usage: cp [-R [-H | -L | -P]] [-fi | -n] [-pvX] source_file target_file
       cp [-R [-H | -L | -P]] [-fi | -n] [-pvX] source_file ... target_directory
make: *** [install.lib] Error 64

Old cp doesn't have a -a flag. Replace this with -pPR which is equivalent and works on any cp, new or old.

Please also check nxproxy and x2go.

[Ionic (Mihai Moldovan)]

Hmm, -pPR is not really always equivalent, the man page on 10.9 for gcp says -a is equivalent to -dR --preserve=all, while Apple's cp says -pPR.

According to the Apple cp usage note, it doesn't know the -d option, though, so meh. It will depend on what cp is being used and if users are crazy enough to add the non-g-prefixed gnubin directory to the PATH value. But that's probably the user's problem...

[ryandesign (Ryan Carsten Schmidt)]

Ah, well for MacPorts purposes, we know it will be Apple's cp, so -pPR is sufficient. If upstream wanted to do something more comprehensive that would be up to them, but as far as a I can see, upstream no longer develops this open source version of the software and has moved to a closed-source model, so it's a moot point.

[Ionic (Mihai Moldovan)]

I am upstream... we're still maintaining and developing nx-libs. ;)

[ryandesign (Ryan Carsten Schmidt)]

Ah, I was basing my response on what I saw at the homepage listed in the port, specifically ​https://www.nomachine.com/version-3 . Are you continuing to develop version 3 elsewhere? Maybe change the port's homepage to match?

[Ionic (Mihai Moldovan)]

Yeah, good point.

I guess I'll just patch the port(s) conditionally in MacPorts, because supporting different cp versions is tricky at best and doesn't really have a huge benefit if it's only used by legacy OS X systems. Not sure about the BSDs, but... FreeBSD supports -a since at 7.1 (they are at 11.0 currently), NetBSD since 6.0 (currently at 7.0) and OpenBSD doesn't have it at all even in the newest version (WTF?).

Good enough to just do it for OS X < 10.6, I guess.

[Ionic (Mihai Moldovan)]

Fixed in r153433.

Will take a look at x2goclient separately.