Opened 4 years ago

Closed 4 years ago

#52545 closed update (fixed)

keybinder @0.3.0: update to version 0.3.1, add new port/subport keybinder-3.0, remove py26-keybinder

Reported by: dbevans (David B. Evans) Owned by: ryandesign (Ryan Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: petrrr
Port: keybinder keybinder-3.0 py26-keybinder

Description (last modified by dbevans (David B. Evans))

keybinder is now at version 0.3.1.

In addition, the deprecated py26-keybinder subport could be removed as requested by petr in #49355.

The keybinder-3.0 issue has been moved to #52590

Attachments (3)

patch-keybinder-0.3.1-diff (6.1 KB) - added by dbevans (David B. Evans) 4 years ago.
Patch for all issues except adding a new keybiinder-3.0 port
patch-py-graveyard-obsolete-py26-keybinder.diff (453 bytes) - added by dbevans (David B. Evans) 4 years ago.
Patch to py-graveyard to obsolete py26-keybinder (typo fixed)
patch-keybinder-0.3.1-with-gtk-doc.diff (6.2 KB) - added by dbevans (David B. Evans) 4 years ago.
Proposed patch updated to enable gtk-docs per GNOME library common usage

Download all attachments as: .zip

Change History (11)

comment:1 Changed 4 years ago by dbevans (David B. Evans)

Keywords: haspatch added

Patch attached that updates keybinder to version 0.3.1 as follows

  • fetch from github since previous download site is missing version 0.3.1
  • update description to clarify this is a GTK2 app
  • configure using autogen.sh to generate an updated configure file
  • add the necessary build dependencies
  • patch configure.ac to remove the use of deprecated GNOME_COMMON_INIT removed in gnome-common @3.18.0
  • patch configure.ac to override the standard python install locations with the MacPorts version specific ones
  • fix argument in configure.args in Portfile that specifies the absolute path to pygtk-codegen-2.0 to work when configuring with autogen.sh
  • remove subport py26-keybindings

Additional patch attached to update py-graveyard to obsolete py26-keybinder

I haven't looked at keybinder-3.0. Not sure whether this should be a subport or a new port. I'm leaning toward new port since it is maintained as a separate github project.

Changed 4 years ago by dbevans (David B. Evans)

Attachment: patch-keybinder-0.3.1-diff added

Patch for all issues except adding a new keybiinder-3.0 port

comment:2 Changed 4 years ago by dbevans (David B. Evans)

Description: modified (diff)
Type: defectupdate

The keybinder-3.0 issue has been moved to separate ticket #52590 for clarity.

comment:3 Changed 4 years ago by dbevans (David B. Evans)

Description: modified (diff)

comment:4 Changed 4 years ago by dbevans (David B. Evans)

Updated patch to enable the build of gtk-doc API docs. GNOME libraries usually include pre-built API docs in the tarball but, since we are now building from scrath, we need to build them ourselves.

Changed 4 years ago by dbevans (David B. Evans)

Patch to py-graveyard to obsolete py26-keybinder (typo fixed)

Changed 4 years ago by dbevans (David B. Evans)

Proposed patch updated to enable gtk-docs per GNOME library common usage

comment:5 Changed 4 years ago by ryandesign (Ryan Schmidt)

Is running autogen.sh really necessary? Would using the release download avoid that need?

comment:6 in reply to:  5 Changed 4 years ago by dbevans (David B. Evans)

Replying to ryandesign@…:

Is running autogen.sh really necessary? Would using the release download avoid that need?

Unfortunately not. As with many github projects (and properly too), the files that are generated by running autogen.sh (configure, etc) are not included in the repo and (I just double checked) the release tar ball is identical to the repo contents. The benefit of this is that you generate configure, etc using the autotools version provided by the build system, not the developer system. Eliminates a possible problem if the autotools used to generate the tarball are really out of date.

The commit hash that I used is identical to the release tag you mention.

comment:7 Changed 4 years ago by dbevans (David B. Evans)

Committed in r154011.

comment:8 Changed 4 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.