Changes between Initial Version and Version 1 of Ticket #52605, comment 19


Ignore:
Timestamp:
Oct 16, 2016, 6:59:00 PM (8 years ago)
Author:
dbevans (David B. Evans)
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #52605, comment 19

    initial v1  
    1 While you were testing, I looked into the `gtk-encode-symbolic-svg` code.  This utility converts svg icon files to specially encoded png files that have many of the properties (color substitution, for example) as svg but with much less processing overhead.
     1While you were testing, I looked into the `gtk-encode-symbolic-svg` code.  This utility converts svg icon files to specially encoded png files that have many of the same properties (color substitution, for example) as svg but with much less processing overhead.
    22
    33`gtk-encode-symbolic-svg` uses the following code to read the svg into an in-memory GdkPixbuf:
    … …  
    2626}}}
    2727
    28 Error handling here is what I would call "minimum magnificent"! If gdk_pixbuf_new_from_stream_at_scale returns an error it is propagated upstream without checks to the main caller which then prints the message we're seeing if an error is set without check which error it is.  Possible errors are those in the GDK_PIXBUF_ERROR domain
     28Error handling here is what I would call "minimum magnificent"! If gdk_pixbuf_new_from_stream_at_scale returns an error it is propagated upstream without checks to the main caller which then prints the message we're seeing without checking which error it is.  Possible errors are those in the GDK_PIXBUF_ERROR domain
    2929{{{
    3030GDK_PIXBUF_ERROR_CORRUPT_IMAGE         An image file was broken somehow.
    … …  
    3939and in the G_IO_ERROR domain (too many to list here) but some sort of GIO stream error is a possibility.
    4040
    41 Lots of possibilities.
     41Lots and lots of possibilities!
    4242
    4343Can you run `gtk-encode-symbolic-svg` under gdb with a breakpoint at `load_symbolic_svg` and step from there to see what error is really being returned?
    … …  
    4949}}}
    5050
    51 So the question is: what is what error is being returned by `load_symbolic_svg`?
     51So the question is: what error is being returned by `load_symbolic_svg`?
    5252
    5353