Opened 4 years ago

Closed 4 years ago

#52609 closed update (fixed)

Update angband port to 4.0.5

Reported by: jfcaron3 Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: haspatch Cc: kurthindenburg (Kurt Hindenburg)
Port: angband

Description

Just update the port. The only changes to the PortFile are the version number and checksums.

The new PortFile is attached.

Attachments (2)

PortFile (2.5 KB) - added by jfcaron3 4 years ago.
Updated PortFile, linted, with maintainer.
patch (1.3 KB) - added by jfcaron3 4 years ago.
"Unified" diff version of the patch.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 4 years ago by jfcaron3

I ran the linter on the portfile and added some newlines accordingly. I am also willing to become the maintainer for this port, so here's a new version of the updated PortFile with my email address in it.

Changed 4 years ago by jfcaron3

Attachment: PortFile added

Updated PortFile, linted, with maintainer.

comment:2 Changed 4 years ago by kurthindenburg (Kurt Hindenburg)

Cc: khindenburg@… added

Thanks, a few comments: 1) upload a diff/patch not the new Portfile 2) separate whitespace and content into 2 patches 3) there's no reason to remove all the empty lines - we typically like having the lines separated.

So just a patch updating version/checksums/maintainer is needed

comment:3 Changed 4 years ago by jfcaron3

Ok here is my attempt at getting a patch. It was unusually difficult to retrieve a version of the Portfile before I made my changes.

comment:4 Changed 4 years ago by mf2k (Frank Schima)

Per the guidelines, please instead attach the patchfile as a unified diff.

Changed 4 years ago by jfcaron3

Attachment: patch added

"Unified" diff version of the patch.

comment:5 in reply to:  4 Changed 4 years ago by jfcaron3

Replying to mf2k:

Per the guidelines, please instead attach the patchfile as a unified diff.

Done.

comment:6 Changed 4 years ago by mf2k (Frank Schima)

Thanks! r154284. In the future, please do not edit the # $Id: line.

comment:7 Changed 4 years ago by ryandesign (Ryan Schmidt)

Keywords: haspatch added; games removed
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.