Opened 2 years ago

Closed 2 years ago

#52619 closed defect (fixed)

ufraw @0.22_4: fails to build due to boolean macro

Reported by: johnm@… Owned by: dbevans (David B. Evans)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc: todmorrison (Tod Morrison), iqgrande, codespleen
Port: ufraw

Description

The ufraw port fails to build due to an issue with the definition of the TRUE macro.

I was attempting to install the gimp port when I encountered this. I'm running macOS Sierra.

:info:build dcraw.cc:2407:10: error: cannot initialize return object of type 'boolean' with an rvalue of type 'int'
:info:build   return TRUE;
:info:build          ^~~~
:info:build /opt/local/include/lcms2.h:254:22: note: expanded from macro 'TRUE'
:info:build #       define TRUE  1
:info:build                      ^
:info:build dcraw.cc:2423:3: error: no matching function for call to 'jpeg_read_header'
:info:build   jpeg_read_header (&cinfo, TRUE);
:info:build   ^~~~~~~~~~~~~~~~
:info:build /opt/local/include/jpeglib.h:1039:13: note: candidate function not viable: no known conversion from 'int' to 'boolean' for 2nd argument
:info:build EXTERN(int) jpeg_read_header JPP((j_decompress_ptr cinfo,
:info:build             ^
:info:build ufraw_developer.c:390:19: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
:info:build     for (try = 0; abs(bg - b) > 0.001 || try < 100; try++) {
:info:build                   ^
:info:build dcraw.cc:2496:5: error: no matching function for call to 'jpeg_read_header'
:info:build     jpeg_read_header (&cinfo, TRUE);
:info:build     ^~~~~~~~~~~~~~~~

Attachments (1)

main.log (33.8 KB) - added by johnm@… 2 years ago.
build log file

Download all attachments as: .zip

Change History (8)

Changed 2 years ago by johnm@…

Attachment: main.log added

build log file

comment:1 Changed 2 years ago by dbevans (David B. Evans)

Cc: devans@… removed
Keywords: sierra added
Owner: changed from macports-tickets@… to devans@…
Status: newassigned
Version: 2.3.4

comment:2 Changed 2 years ago by todmorrison (Tod Morrison)

Cc: todmorrison@… added

Cc Me!

comment:3 Changed 2 years ago by iqgrande

Cc: iqgrande added

comment:4 Changed 2 years ago by dbevans (David B. Evans)

Status: assignedaccepted

comment:5 Changed 2 years ago by dbevans (David B. Evans)

Cc: codespleen added
Keywords: sierra removed

Has duplicate #52714.

comment:6 Changed 2 years ago by dbevans (David B. Evans)

Fix committed in r154304.

comment:7 Changed 2 years ago by dbevans (David B. Evans)

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.