Opened 7 years ago

Last modified 6 years ago

#52675 accepted defect

trac: "CC Me" button not displayed properly

Reported by: mkae (Marko Käning) Owned by: neverpanic (Clemens Lang)
Priority: Low Milestone:
Component: trac Version:
Keywords: Cc:
Port:

Description

The button icon looks odd on my Android's Firefox.

Change History (12)

comment:1 Changed 7 years ago by mkae (Marko Käning)

Perhaps it only looks badly aligned on my mobile. Have to check on my iMac's browsers as well...

Last edited 7 years ago by mkae (Marko Käning) (previous) (diff)

comment:2 Changed 7 years ago by ryandesign (Ryan Carsten Schmidt)

Can you attach a screenshot of the problem?

It looks ok on desktop Safari, except that it's written in about 7pt text, which is almost illegibly small for me. Almost the same could be said for the Reply Edit Delete and other buttons Trac includes by default. They look like they're about 9pt, which is still much smaller than is ideal.

comment:3 Changed 7 years ago by mkae (Marko Käning)

Yeah, that's about it. The alignment to the bottom line doesn't make it fancier... Saw that one can configure in trac's preferences whether only icons or also text should be displayed...

comment:4 Changed 7 years ago by neverpanic (Clemens Lang)

Owner: changed from admin@… to neverpanic
Status: newaccepted

Well, the icon is a unicode letter (as in mail) symbol. I agree it looks bad at this size. I think the problem is that .inlinebuttons input uses a relative font-size of 70%, which makes buttons in the ticket properties even smaller because those are already scaled by 80%. We should fix that in the CcMe plugin.

comment:5 Changed 7 years ago by mkae (Marko Käning)

Here on my Safari the CC's letter icon looks tiny. I guess it deserves the size of "Reply" and "Edit" buttons' icons. :)

comment:6 Changed 7 years ago by neverpanic (Clemens Lang)

Source is https://github.com/neverpanic/trac-ccme, see ccme/htdocs/css/ccme.css, just in case somebody wants to prepare a patch.

comment:7 Changed 7 years ago by mkae (Marko Käning)

Ooops, just tried to fork above repo of yours and turns out GitHub actively forbade that for me just now with the message:

You don’t have permission to fork to these organizations:

@macports macports

Is that intended or an overly strict default setting of GitHub?

comment:8 in reply to:  7 Changed 7 years ago by raimue (Rainer Müller)

As a member of an organization, GitHub will ask you where you want to create the fork. You are not supposed to choose the MacPorts organization in this dialog, but instead your own user account.

comment:9 Changed 7 years ago by mkae (Marko Käning)

OK, I wasn't aware of that I simply had to click my avatar to proceed.

Thanks for triggering me becoming aware of this!

comment:10 in reply to:  6 Changed 7 years ago by larryv (Lawrence Velázquez)

I have several related quibbles about the aesthetics of NewTrac (mainly the tiny type scattered everywhere), but we should probably not spend time on such things until we’re done with the GitHub migration.

comment:11 Changed 7 years ago by neverpanic (Clemens Lang)

Priority: NormalLow

I agree.

comment:12 Changed 6 years ago by neverpanic (Clemens Lang)

Component: server/hostingtrac
Note: See TracTickets for help on using tickets.