Opened 4 years ago

Closed 4 years ago

#52706 closed update (fixed)

emacs-app @24.5: update to 25.1

Reported by: isomarcte (David Strawn) Owned by: humem (humem)
Priority: Normal Milestone:
Component: ports Version:
Keywords: haspatch Cc: drkp (Dan Ports)
Port: emacs-app

Description

I have upgraded the emacs-app port for emacs 25.1. This includes the porting the inline patch for emacs 25.1.

I am a bit confused about why the inline variant is on by default, so in the attached file I disabled it by default. It seems, at least to me, to be surprising for the average user. Normally, I'd expect the default install of a port to be as close as possible to the upstream codebase, with variants adding customizations or extra features. This does seem to be what the macports guide itself recommends, https://guide.macports.org/#development.variants.default .

Anyway, I hope it is helpful, let me know if I can change/fix anything. I have been running the 25.1 build locally for the past week using the given Portfile, off and on with the inline patch, and have thus far had no problems.

Attachments (2)

patch-inline-25.1-20151017.diff (40.5 KB) - added by isomarcte (David Strawn) 4 years ago.
Updated inline patch
Portfile-emacs-app.diff (1.5 KB) - added by isomarcte (David Strawn) 4 years ago.
Updated Portfile

Download all attachments as: .zip

Change History (8)

Changed 4 years ago by isomarcte (David Strawn)

Updated inline patch

comment:1 in reply to:  description Changed 4 years ago by larryv (Lawrence Velázquez)

Cc: hum@… removed
Owner: changed from macports-tickets@… to hum@…
Status: newassigned
Summary: emacs-app 25.1emacs-app @24.5: update to 25.1
Version: 2.3.4

Replying to isomarcte:

I am a bit confused about why the inline variant is on by default, so in the attached file I disabled it by default. It seems, at least to me, to be surprising for the average user. Normally, I'd expect the default install of a port to be as close as possible to the upstream codebase, with variants adding customizations or extra features. This does seem to be what the macports guide itself recommends, https://guide.macports.org/#development.variants.default .

It’s up to the maintainer. We do not recommend or discourage adhering to the “upstream” configuration, although we do discourage overly fussy variants. Many maintainers choose to enable optional features without providing variants at all.

Since you’re updating version, you must remove the revision line.

Changed 4 years ago by isomarcte (David Strawn)

Attachment: Portfile-emacs-app.diff added

Updated Portfile

comment:2 Changed 4 years ago by isomarcte (David Strawn)

Oops. Thanks for catching that! Updated.

comment:3 Changed 4 years ago by isomarcte (David Strawn)

Looks like I also put the wrong date on the inline patch...definitely is not 2015...

I don't see any way to rename a file, just replace them. So I am leaving it as is.

comment:4 Changed 4 years ago by iqgrande

Greetings:

I just opened up #52831 and I think it may be helped by emacs-app getting updated as well.

Kind regards, Anthony

comment:5 Changed 4 years ago by drkp (Dan Ports)

Cc: drkp added

comment:6 Changed 4 years ago by drkp (Dan Ports)

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.