Opened 4 years ago

Closed 3 years ago

#52707 closed enhancement (wontfix)

trac: Provide search link to port file(s)

Reported by: mkae (Marko Käning) Owned by: admin@…
Priority: Normal Milestone:
Component: trac Version:
Keywords: Cc: raimue (Rainer Müller), mojca (Mojca Miklavec)
Port:

Description

trac could provide a search link to ports based on contents of ports data field in ticket table (port field of ticket already links to ticket line for respective port). This would allow a reviewer to have immediate access to the currently existing port files as well as their content in the browser without the need for an additional console.

Change History (11)

comment:1 Changed 4 years ago by raimue (Rainer Müller)

Cc: raimue@… added
Component: wikiserver/hosting
Keywords: trac removed
Owner: changed from macports-tickets@… to admin@…
Status: newassigned

Let me ask for clarification here:

  • Trac tickets against specific ports should provide a link to the current Portfile (or ports directory?)
  • Where would you expect such a link in the ticket UI?

comment:2 in reply to:  1 Changed 4 years ago by mkae (Marko Käning)

Replying to raimue:

  • Trac tickets against specific ports should provide a link to the current Portfile (or ports directory?)

Good point, port dir is even better!

  • Where would you expect such a link in the ticket UI?

It would certainly be best if it was shown in the ticket UI and not (only) in the ticket table.

I imagined all along that the link would be made from the corresponding port field entry, but that has recently been connected to the ticket line already. Bad luck for my proposal, as I am too late... Well, one has to consider as well that the ticket addresses more than one port and thus the user would like to have fast access to all items in that list or ports.

So you could just add an additional line to the bottom if the ticket's header below the "Port:" entry called perhaps "Port Directories:" or something along those lines...

comment:3 Changed 4 years ago by ryandesign (Ryan Schmidt)

What should happen when the Port field contains the name of a subport?

comment:4 in reply to:  3 ; Changed 4 years ago by mkae (Marko Käning)

Replying to ryandesign:

What should happen when the Port field contains the name of a subport?

Open the portdir which contains the subport.

One could also take into account that the string entered into the port edit field might be a regular expression (e.g. kmymoney4(-devel)) which would require generating more than one link per expression. [Well, I am aware of that this is probably a special case not met that often.]

Last edited 4 years ago by mkae (Marko Käning) (previous) (diff)

comment:5 Changed 4 years ago by mkae (Marko Käning)

Mockup:

...
Port:     aqbanking5(.*-devel) kmymoney4(-devel)
Portdir:  aqbanking5 aqbanking5-devel aqbanking5-gtk-devel kmymoney4 kmymoney4-devel
---
Description

Note the expansion of the list of port dirs according to which ports could be found for the regular expression given. Every entry would be linked to the corresponding port dir in the repo.

But, probably one would need such an expansion of the list also for the 'Port' data field... OTOH one should be able to pass on that regular expression to the ticket line URLs which create the list of existing tickets for all matching (sub)ports.

comment:6 in reply to:  4 ; Changed 4 years ago by ryandesign (Ryan Schmidt)

Replying to mkae:

Replying to ryandesign:

What should happen when the Port field contains the name of a subport?

Open the portdir which contains the subport.

What I was trying to point out is that Trac does not currently have that information. It does not know that some ports are subports, and what their portdirs are.

One could also take into account that the string entered into the port edit field might be a regular expression (e.g. kmymoney4(-devel)) which would require generating more than one link per expression. [Well, I am aware of that this is probably a special case not met that often.]

I would consider this a user error, not something we want to support. The Port field should contain port and subport names, not regular expressions.

comment:7 in reply to:  6 Changed 4 years ago by mkae (Marko Käning)

Replying to ryandesign:

What I was trying to point out is that Trac does not currently have that information. It does not know that some ports are subports, and what their portdirs are.

I see. This means one would need a plugin which would have to figure all that out.

I would consider this a user error, not something we want to support. The Port field should contain port and subport names, not regular expressions.

Well, I'd rather like to consider this a feature request, which I wanted to demo with my mockup.

But, on second thought I realize that this might easily break too. Think of a regex match at a later point in time, e.g. if I'd create a port aqbanking5-git-devel which would be matched as well above but which I didn't want to address in an earlier filed ticket.

Last edited 4 years ago by mkae (Marko Käning) (previous) (diff)

comment:8 Changed 4 years ago by raimue (Rainer Müller)

Yes, this request will require a new plugin. I was asking what it should look like before we can even start to develop this. However, this will be blocked by getting the PortIndex to DB conversion running on the buildbot first.

Using any kind of wildcards, regex, etc. for multiple ports the port field will break he filtering. You will have to list port names only. We could perhaps think about automatic expansion in Trac, but it is usually better to just do that locally with port echo to verify your intended result before submitting.

comment:9 Changed 4 years ago by mkae (Marko Käning)

Yes, Rainer, I fully agree.

comment:10 Changed 4 years ago by mojca (Mojca Miklavec)

Cc: mojca added

comment:11 Changed 3 years ago by neverpanic (Clemens Lang)

Component: server/hostingtrac
Resolution: wontfix
Status: assignedclosed

I'm closing this because I don't think we will ever get to it. If somebody wants to provide a plugin that does this, I'm happy to support.

Note: See TracTickets for help on using tickets.