Changes between Initial Version and Version 3 of Ticket #52739


Ignore:
Timestamp:
Oct 29, 2016, 7:08:18 AM (5 years ago)
Author:
mojca (Mojca Miklavec)
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #52739

    • Property Cc larryv dbevans added
    • Property Version changed from 2.3.4 to
  • Ticket #52739 – Description

    initial v3  
    1 The .bundle files are not built with arch flags, so they do not respect build_arch and are not built universal.[[BR]]
     1The `.bundle` files are not built with arch flags, so they do not respect `build_arch` and are not built universal.[[BR]]
    22Attached are several proposed solutions.
    33
    4 * Portfile1.diff adds {{{-Alddlflags="$LDFLAGS"}}} to configure.post_args. It adds the arch flags, but it also adds {{{-L/opt/local/lib -Wl,-headerpad_max_install_names}}}, which might not be desirable.
     4* [attachment:"Portfile1.diff" Portfile1.diff] adds `-Alddlflags="$LDFLAGS"` to `configure.post_args`. It adds the arch flags, but it also adds `-L/opt/local/lib -Wl,-headerpad_max_install_names`, which might not be desirable.
    55
    6 * Portfile2.diff and Portfile2.diff just add {{{"-Alddlflags=\"[get_canonical_archflags ld]\""}}} to configure.post_args. Extra code, however, is required to make {{{get_canonical_archflags}}} work correctly. {{{get_canonical_archflags}}} determines if universal flags are required using the following code:
    7 {{{
    8         if {![variant_exists universal] || ![variant_isset universal]} {
    9 }}}
    10 When configure.post_args-append is run, however, the universal variant has not yet been created.
    11 I assume this is to give the Portfile a chance to create its own.
     6* [attachment:"Portfile2.diff" Portfile2.diff] and [attachment:"Portfile3.diff" Portfile3.diff] just add `"-Alddlflags=\"[get_canonical_archflags ld]\""` to `configure.post_args`. Extra code, however, is required to make `get_canonical_archflags` work correctly. `get_canonical_archflags` determines if universal flags are required using the following code:
     7    {{{
     8    if {![variant_exists universal] || ![variant_isset universal]} {
     9    }}}
     10  When `configure.post_args-append` is run, however, the universal variant has not yet been created.
     11  I assume this is to give the `Portfile` a chance to create its own.