Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#52766 closed enhancement (fixed)

buildbot: portwatcher should trigger portbuilder builds in predictable order

Reported by: ryandesign (Ryan Schmidt) Owned by: neverpanic (Clemens Lang)
Priority: High Milestone:
Component: buildbot/mpbb Version:
Keywords: buildbot Cc: mojca (Mojca Miklavec)


Currently, portwatcher triggers portbuilder builds in random order. (Well, they're triggered in alphabetical order, but buildbot then adds them to an unordered python dictionary from which they're pulled out in random order.)

Per a suggestion on the buildbot users mailing list, we should add a custom "priority" property to each triggered build, and then write a nextBuild function which determines which of the pending BuildRequests to build next by examining their "priority" properties.

Once this is working and causing builds to happen in alphabetical order, we can try to do the more complicated dependency order.

Change History (8)

comment:1 Changed 6 years ago by mojca (Mojca Miklavec)

Cc: mojca added

comment:2 Changed 6 years ago by mojca (Mojca Miklavec)

Keywords: buildbot added

comment:3 Changed 5 years ago by neverpanic (Clemens Lang)

Priority: NormalHigh

comment:4 Changed 5 years ago by neverpanic (Clemens Lang)

Component: server/hostingbuildbot/mpbb

comment:5 Changed 5 years ago by mojca (Mojca Miklavec)

In bf29a890d45aea8c4627c01f289cf45e0f1eebf7/macports-infrastructure:

buildbot: Guarantee stable order of builds

See: #52766

comment:6 Changed 5 years ago by neverpanic (Clemens Lang)

Owner: changed from admin@… to neverpanic
Status: newassigned

Thanks. Now we need to sort the output of list-subports in dependency order.

comment:7 Changed 5 years ago by jmroot (Joshua Root)

Resolution: fixed
Status: assignedclosed

In 97f4db4f3eabaabcf005b0758a3b32d36525c395/mpbb:

List subports in dependency order

Closes: #52766

comment:8 Changed 5 years ago by jmroot (Joshua Root)

In 3521080355275ad6f48a9e2036b296fe1cae30aa/macports-infrastructure:

buildbot: don't sort the subports

They're already sorted in dependency order, which is what we want, so
it's no good sorting alphabetically.

Fixes: #52766

Note: See TracTickets for help on using tickets.