Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#52824 closed defect (fixed)

gnuradio-devel +ctrlport variant does not work

Reported by: kpreid (Kevin Reid) Owned by: macports-tickets@…
Priority: Normal Milestone:
Component: ports Version: 2.3.4
Keywords: Cc: michaelld (Michael Dickens)
Port: gnuradio-devel

Description

I have

$ port installed gnuradio-devel
...
  gnuradio-devel @20161028_0+ctrlport+docs+grc+performance_counters+qtgui+sdl+swig+uhd+wavelet+wxgui (active)

but gnuradio tells me that it does not actually have ctrlport or performance_counters (which depends on ctrlport)

$ gnuradio-config-info --enabled-components
python-support;testing-support;doxygen;sphinx;gnuradio-runtime;gr-blocks;gnuradio-companion;gr-fec;gr-fft;gr-filter;gr-analog;gr-digital;gr-dtv;gr-atsc;gr-audio;* osx;gr-channels;gr-noaa;gr-pager;gr-qtgui;gr-trellis;gr-uhd;gr-utils;gr-video-sdl;gr-vocoder;gr-fcd;gr-wavelet;gr-wxgui

Attachments (1)

gnuradio_enable_ctrlport.diff (2.7 KB) - added by michaelld (Michael Dickens) 7 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 7 years ago by michaelld (Michael Dickens)

+ctrlport is currently disabled, because thrift wasn't playing nice on OS X back a year or so ago. I'll try again & see if it works.

+performance_counters should be build-able using the eponymous variant. I'll don't usually build with this variant. I'll try it & see if it works for me. At least doing "port configure gnuradio-devel +performance_counters" and then looking at the logfile I find that performance_counters is enabled (via the line "ADDING PERF COUNTERS" only; there is no other acknowledgement that I know of that performance_counters is enabled; I don't know if this should be listed in the gnuradio-config-info, but I kinda doubt it).

comment:2 Changed 7 years ago by michaelld (Michael Dickens)

+performance_counters does not result in gnuradio-config-info showing that it is enabled. Hopefully it is actually enabled & you can do testing to verify that performance_counters are working.

comment:3 Changed 7 years ago by kpreid (Kevin Reid)

I wanted to debug a complex flow graph so I was particularly hoping to run gr-perf-monitorx (which requires both features) rather than reimplementing the same sort of thing from within my application; but I have confirmed that I can enable and use the pc_* methods so the +performance_counters variant seems to be OK as you said.

Changed 7 years ago by michaelld (Michael Dickens)

comment:4 Changed 7 years ago by michaelld (Michael Dickens)

I attached a patch that works for me to get +ctrlport to build. "make test" still fails, but that might be because the tests aren't working. I'm looking into a good way to test whether Thrift is working for ctrlport or not. Maybe someone here can test it?

comment:5 Changed 7 years ago by michaelld (Michael Dickens)

I'm going to commit this change, now that py*-thrift is updated to same as thrift (0.10.0) -- since it seems to get ctrlport to work as well as it ever has on the Mac. Please test & if there are issues open a new ticket with those issues (GNURadio runtime) since this ticket is about getting +ctrlport working (MacPorts issue).

comment:6 Changed 7 years ago by michaelld (Michael Dickens)

In fac6cca0/macports-ports:

gnuradio*: enable +ctrlport

Also fix +cxx11 to work, since thrift code requires c++11.
Addresses ticket #52824 .

comment:7 Changed 7 years ago by michaelld (Michael Dickens)

Resolution: fixed
Status: newclosed

comment:8 Changed 7 years ago by kpreid (Kevin Reid)

I went to test this out and could not fetch py27-thrift. Filed #53782 for that.

Note: See TracTickets for help on using tickets.