openttd @1.5.2 compile error

[lukeodom]

Compile fails with following error:

/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_release_ports_games_openttd/openttd/work/openttd-1.5.2/src/music/cocoa_m.cpp:76:4: error: no matching function for call to 'AUGraphNodeInfo'

Full log attached

[neverpanic (Clemens Lang)]

This is weird… so a year ago when updating to 1.5.2, I wrote the patches required to get it building on modern OS X and committed them ([0e914b1a5bc753409ff20b8f21bc07e8cd9ad84c/macports-ports]). I then opened a ticket upstream (​https://bugs.openttd.org/task/6380) and even referenced that ticket in the patches ([e24ba54d964b24a442dce9e48de11533118a1136/macports-ports]).

But do you know what I forgot? Adding the patchfiles to the Portfile so they would actually be applied. Stupid me. Fix inbound, will include update to 1.6.1.

[neverpanic (Clemens Lang)]

In bd48c2b2/macports-ports:

openttd: 1.6.1, actually apply the patches I wrote

It seems when updating to 1.5.2 I wrote the patches required to fix the
build on modern OS X, even submitted them upstream, but then failed to
actually enable them in the Portfile.

Update one of the patches with a newer suggestion from the upstream
ticket, update to 1.6.1 and enable the patches.

Closes: #52841