Opened 7 years ago

Closed 6 years ago

#52968 closed update (fixed)

Port update for libvirt (1.3.5 -> 2.4.0), and new Perl bindings for libvirt

Reported by: akkornel (A. Karl Kornel) Owned by: ryandesign (Ryan Carsten Schmidt)
Priority: Normal Milestone:
Component: ports Version:
Keywords: Cc:
Port: libvirt

Description

Hello! I have an update to the libvirt port, updating it to version 2.4.0. I also have a new, related port: p5-sys-virt, which is the Perl bindings for libvirt.

Ryan is listed as the maintainer with an openmaintainer policy, so could someone please assign this to him? Thanks very much!

There have been a number of changes since the last update of libvirt:

  • The software is now distributed as a .tar.xz (it used to be a .tar.gz).
  • FUSE support has been added.
  • OpenSSL support has been added (an optional replacement for GNUTLS). Presumably that means LibreSSL will also work.
  • It is now possible to have libvirt manage QEMU VMs.

I decided to make p5-sys-virt a separate port because the Perl binding is distributed separately from libvirt, so having p5-sys-virt be a subport of libvirt seemed too messy.

I'm attaching two files:

  • A new Portfile for p5-sys-virt
  • An updated Portfile for libvirt

You can also see my changes on Github, using this URL: ​https://github.com/macports/macports-ports/compare/master...akkornel:libvirt?expand=1

Please let me know if you have any questions or comments. Thanks much!

Attachments (3)

libvirt Portfile​ (3.7 KB) - added by akkornel (A. Karl Kornel) 7 years ago.
libvirt Portfile
p5-sys-virt Portfile​ (1.1 KB) - added by akkornel (A. Karl Kornel) 7 years ago.
p5-sys-virt Portfile
diff​ (3.8 KB) - added by akkornel (A. Karl Kornel) 7 years ago.
Diff showing changes (v2)

Download all attachments as: .zip

Change History (9)

Changed 7 years ago by akkornel (A. Karl Kornel)

Attachment: libvirt Portfile​ added

libvirt Portfile

Changed 7 years ago by akkornel (A. Karl Kornel)

Attachment: p5-sys-virt Portfile​ added

p5-sys-virt Portfile

comment:1 Changed 7 years ago by mf2k (Frank Schima)

Cc: ryandesign removed
Owner: set to ryandesign
Status: new → assigned

Thanks. ​Per the guidelines, please instead attach a unified diff of the libvirt Portfile so we can easily see what changes you are proposing.

comment:2 Changed 7 years ago by akkornel (A. Karl Kornel)

OK, diff has been attached!

comment:3 Changed 7 years ago by mf2k (Frank Schima)

Looks very good. Some comments:

libvert:

  • Use the line use_xz yes instead of manually setting extract.suffix and adding the depends_extract port:xz line

p5-sys-virt:

  • openmaintainer by itself is invalid. Use nomaintainer instead.
  • The stub port should have no dependencies. So remove the else clause entirely.

Changed 7 years ago by akkornel (A. Karl Kornel)

Attachment: diff​ added

Diff showing changes (v2)

comment:4 Changed 7 years ago by akkornel (A. Karl Kornel)

Got it. Both set of comments have been incorporated, and a new diff attached!

comment:5 Changed 6 years ago by raimue (Rainer Müller)

Pull request for 4.1.0: ​https://github.com/macports/macports-ports/pull/1462

I did not include the perl module. I don't know whether to package them from CPAN or upstream directly and I am not able to test these bindings.

comment:6 Changed 6 years ago by raimue (Rainer Müller)

Resolution: → fixed
Status: assigned → closed

In a7569ad6979430ec1a25165ca5f7263db79204e0/macports-ports:

libvirt: Update to version 4.1.0

Closes: #52968

Note: See TracTickets for help on using tickets.