buildbot: builds with linking errors are not handled properly

[mojca (Mojca Miklavec)]

See the following ​weird build:

• it ended up being displayed as successful despite the failure
• some (build) dependency was activated during port install (shouldn't it be activated during installation of dependencies?)

--->  Activating php53-curl @5.3.29_0
DEBUG: Using /usr/bin/tar
DEBUG: Using /usr/bin/bzip2
x ./
x ./+COMMENT
x ./+CONTENTS
x ./+DESC
x ./+PORTFILE
x ./+STATE
x ./opt/
x ./opt/local/
x ./opt/local/lib/
x ./opt/local/var/
x ./opt/local/var/db/
x ./opt/local/var/db/php53/
x ./opt/local/var/db/php53/curl.ini
x ./opt/local/lib/php53/
x ./opt/local/lib/php53/extensions/
x ./opt/local/lib/php53/extensions/no-debug-non-zts-20090626/
x ./opt/local/lib/php53/extensions/no-debug-non-zts-20090626/curl.so
...
--->  Updating database of binaries
DEBUG: Updating binary flag for file 1 of 2: /opt/local/lib/php53/extensions/no-debug-non-zts-20090626/curl.so
DEBUG: Updating binary flag for file 2 of 2: /opt/local/var/db/php53/curl.ini
--->  Scanning binaries for linking errors
Could not open /opt/local/lib/libidn.11.dylib: Error opening or reading file (referenced from /opt/local/lib/php53/extensions/no-debug-non-zts-20090626/curl.so)
DEBUG: Marking /opt/local/lib/php53/extensions/no-debug-non-zts-20090626/curl.so as broken
--->  Found 1 broken file(s), matching files to ports
--->  Found 1 broken port(s), determining rebuild order
DEBUG: Broken: php53-curl
DEBUG: Processing port php53-curl @0:5.3.29_0  
--->  Rebuilding in order
     php53-curl @5.3.29 
...
--->  Computing dependencies for php53-curl
--->  Dependencies to be installed: autoconf
--->  Activating autoconf @2.69_5
--->  Deactivating php53-curl @5.3.29_0
--->  Cleaning php53-curl
--->  Removing work directory for php53-curl
--->  Uninstalling php53-curl @5.3.29_0
--->  Cleaning php53-curl
--->  Removing work directory for php53-curl
--->  Computing dependencies for php53-curl
--->  Installing php53-curl @5.3.29_0
DEBUG: Can't run install on this port without elevated privileges. Escalating privileges back to root.
DEBUG: euid changed to: 0. egid changed to: 0.
DEBUG: Executing org.macports.install (php53-curl)
DEBUG: Using /usr/bin/tar
DEBUG: Using /usr/bin/bzip2
Error: org.macports.install for port php53-curl returned: no destroot found at: /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_php/php53-curl/work/destroot
DEBUG: Error code: NONE
DEBUG: Backtrace: no destroot found at: /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_lang_php/php53-curl/work/destroot
    while executing
"create_archive $location $portarchivetype"
    (procedure "portinstall::install_main" line 22)
    invoked from within
"portinstall::install_main org.macports.install"
    ("eval" body line 1)
    invoked from within
"eval $procedure $targetname"
Warning: targets not executed for php53-curl: org.macports.activate org.macports.install
Please see the log file for port php53-curl for details:
    /opt/local/var/macports/logs/_opt_bblocal_var_buildworker_ports_build_ports_lang_php/php53-curl/main.log
DEBUG: Rebuilding port php53-curl finished with status 0
--->  Scanning binaries for linking errors
--->  No broken files found.